From: Ralph Siemsen <rsiemsen@rossvideo.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux PPC Dev <linuxppc-dev@lists.linuxppc.org>,
Matt Porter <mporter@kernel.crashing.org>
Subject: Re: [PATCH] 44x ethernet MDIO access
Date: Fri, 06 Aug 2004 09:04:07 -0400 [thread overview]
Message-ID: <411381C7.4010705@rossvideo.com> (raw)
In-Reply-To: <Pine.GSO.4.58.0408061411220.26252@waterleaf.sonytel.be>
Geert Uytterhoeven wrote:
>>- udelay(MDIO_DELAY);
>>+ count = 0;
>>+ while (((stacr = in_be32(&emacp->em0stacr) & EMAC_STACR_OC) == 0)
>>+ && (count++ < 5000))
>
> ^^^^
> MDIO_DELAY?
>
> And perhaps you want to create a (possibly inlined) function just for this
> loop?
Good catch - yes, should be MDIO_DELAY not 5000. I had found that 50
was not enough so I had upped it in my testing - forgot to change it back :(
I'd also suggest the default MDIO_DELAY be increased from its present
value of 50 to perhaps 100 or 150... Does anyone know what the slowest
possible EPB clock speed is?
-R
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-08-06 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-05 19:01 [PATCH] 44x ethernet MDIO access Ralph Siemsen
2004-08-05 20:05 ` Ralph Siemsen
2004-08-05 21:34 ` Matt Porter
2004-08-06 12:12 ` Geert Uytterhoeven
2004-08-06 13:04 ` Ralph Siemsen [this message]
2004-08-05 21:23 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=411381C7.4010705@rossvideo.com \
--to=rsiemsen@rossvideo.com \
--cc=geert@linux-m68k.org \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.