From: Jeff Garzik <jgarzik@pobox.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Matthew Wilcox <willy@debian.org>
Subject: Re: [2.6.8-rc4-bk] NFS oops on x86-64
Date: Fri, 13 Aug 2004 22:22:19 -0400 [thread overview]
Message-ID: <411D775B.1050005@pobox.com> (raw)
In-Reply-To: <1092447909.4078.18.camel@lade.trondhjem.org>
Trond Myklebust wrote:
> På fr , 13/08/2004 klokka 21:07, skreiv Jeff Garzik:
>
>>See attached... oops in BK-latest NFS client on x86-64. The oops is
>>100% reproducible, and occurs immediately (as soon as I access any
>>portion of the mounted NFS filesystem; the mount itself succeeds).
>>
>
>
> Does reverting Willy's borken patch fix it? That patch was clearly never
> actually tested before Linus applied it.
>
> I can see 2 problems in the NFS code alone:
>
> 1) Replacing a test for whether or not O_APPEND and O_DIRECT are
> *both* set with one that checks whether either is set.
> 2) Adding a wonderful check in nfs_open() that causes it to return
> immediately if this new nfs_check_flags() returns 0 (i.e. OK).
>
> GRRRR
Yep, reverting the following patch fixes the NFS oops on x86-64...
ChangeSet@1.1964, 2004-08-13 09:48:04-07:00, willy@debian.org
[PATCH] Remove fcntl f_op
The newly introduced ->fcntl file_operation is badly thought out,
not to mention undocumented. This patch replaces it with two better
defined operations -- check_flags and dir_notify. Any other fcntl()s
that filesystems are interested in can have their own properly typed
f_op method when they need it.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
prev parent reply other threads:[~2004-08-14 2:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-14 1:07 [2.6.8-rc4-bk] NFS oops on x86-64 Jeff Garzik
2004-08-14 1:45 ` Trond Myklebust
2004-08-14 2:21 ` Trond Myklebust
2004-08-14 2:24 ` Trond Myklebust
2004-08-14 2:42 ` Jeff Garzik
2004-08-14 3:23 ` [PATCH] " Jeff Garzik
2004-08-14 2:22 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=411D775B.1050005@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.