From: Jeff Garzik <jgarzik@pobox.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [2.6.8-rc4-bk] NFS oops on x86-64
Date: Fri, 13 Aug 2004 22:42:10 -0400 [thread overview]
Message-ID: <411D7C02.80402@pobox.com> (raw)
In-Reply-To: <1092450265.4078.37.camel@lade.trondhjem.org>
Trond Myklebust wrote:
> På fr , 13/08/2004 klokka 22:21, skreiv Trond Myklebust:
>
>
>>--- linux-2.6.8-rc4/fs/nfs/file.c.orig 2004-08-13 14:21:25.000000000 -0400
>>+++ linux-2.6.8-rc4/fs/nfs/file.c 2004-08-13 21:50:28.000000000 -0400
>>@@ -72,7 +72,7 @@ struct inode_operations nfs_file_inode_o
>>
>> static int nfs_check_flags(int flags)
>> {
>>- if (flags & (O_APPEND | O_DIRECT))
>>+ if (flags & (O_APPEND | O_DIRECT) == (O_APPEND | O_DIRECT))
>> return -EINVAL;
>
> Argh... I'm making mistakes too now...
>
> Should be
>
> if ((flags & (O_APPEND | O_DIRECT)) == (O_APPEND | O_DIRECT))
I'll check this out in a bit.
Update: looks like NFS is dead on 32-bit x86 as well. Same symptoms
and same fix.
Jeff
next prev parent reply other threads:[~2004-08-14 2:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-14 1:07 [2.6.8-rc4-bk] NFS oops on x86-64 Jeff Garzik
2004-08-14 1:45 ` Trond Myklebust
2004-08-14 2:21 ` Trond Myklebust
2004-08-14 2:24 ` Trond Myklebust
2004-08-14 2:42 ` Jeff Garzik [this message]
2004-08-14 3:23 ` [PATCH] " Jeff Garzik
2004-08-14 2:22 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=411D7C02.80402@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.