From: Jeff Garzik <jgarzik@pobox.com>
To: Mike_Phillips@URSCorp.com
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Neil Horman <nhorman@redhat.com>,
Pete Zaitcev <zaitcev@redhat.com>
Subject: Re: [Patch} to fix oops in olympic token ring driver on media disconnect
Date: Mon, 16 Aug 2004 11:18:53 -0400 [thread overview]
Message-ID: <4120D05D.3020602@pobox.com> (raw)
In-Reply-To: <OF11E315D2.D4CBAED1-ON85256EF2.0052F29D-85256EF2.0053587E@urscorp.com>
Mike_Phillips@URSCorp.com wrote:
>>Well, regardless, Neil's patch is IMO a good first step.
>
>
> Neil's patch is to make the annoying regression test failure go away. To
> be honest I have had *one* user email me that this is a problem and once I
> gave them the "don't remove the cable on token ring, its not ethernet"
> talk, they were fine.
Well I
* disagree the kernel should oops,
* I disagree that olympic should call free_irq in the interrupt handler, and
* I disagree that olympic should do 'dev->stop = NULL' at all, much less
in the interrupt handler
sorry,
Jeff
next prev parent reply other threads:[~2004-08-16 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-13 19:11 [Patch} to fix oops in olympic token ring driver on media disconnect Neil Horman
2004-08-13 22:07 ` Alan Cox
2004-08-13 23:35 ` Pete Zaitcev
2004-08-13 23:48 ` Jeff Garzik
2004-08-14 0:06 ` Neil Horman
2004-08-16 15:10 ` Mike_Phillips
2004-08-16 15:18 ` Jeff Garzik [this message]
2004-08-17 0:08 ` Pete Zaitcev
2004-08-17 0:42 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4120D05D.3020602@pobox.com \
--to=jgarzik@pobox.com \
--cc=Mike_Phillips@URSCorp.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.