All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Will Deacon <will.deacon@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"jgunthorpe@obsidianresearch.com"
	<jgunthorpe@obsidianresearch.com>
Subject: Re: [PATCH v2 3/3] PCI: ARM: add support for generic PCI host controller
Date: Thu, 13 Feb 2014 13:21:04 +0100	[thread overview]
Message-ID: <4122896.snWHKCSulY@wuerfel> (raw)
In-Reply-To: <20140213120042.GE13576@mudshark.cambridge.arm.com>

On Thursday 13 February 2014 12:00:42 Will Deacon wrote:
> > With the patch I just suggested, we can simply keep
> > pci_common_init_dev() for older (non-multiplatform) controllers 
> > and not change them at all but move on to something else for
> > the interesting ones, i.e. those we want to share with arm64.
> 
> Yes, that looks sensible. An alternative is to create an hw_pci in
> pci_host_bridge_register with nr_controllers = 1 then call
> pci_common_init_dev. It would remove slightly more code, but obviously ties
> the thing to arm.

You'd still need to pass all the contents of the hw_pci struct that
get copied into pci_sys_data, so that's not different from passing
hw_pci as we do today.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/3] PCI: ARM: add support for generic PCI host controller
Date: Thu, 13 Feb 2014 13:21:04 +0100	[thread overview]
Message-ID: <4122896.snWHKCSulY@wuerfel> (raw)
In-Reply-To: <20140213120042.GE13576@mudshark.cambridge.arm.com>

On Thursday 13 February 2014 12:00:42 Will Deacon wrote:
> > With the patch I just suggested, we can simply keep
> > pci_common_init_dev() for older (non-multiplatform) controllers 
> > and not change them at all but move on to something else for
> > the interesting ones, i.e. those we want to share with arm64.
> 
> Yes, that looks sensible. An alternative is to create an hw_pci in
> pci_host_bridge_register with nr_controllers = 1 then call
> pci_common_init_dev. It would remove slightly more code, but obviously ties
> the thing to arm.

You'd still need to pass all the contents of the hw_pci struct that
get copied into pci_sys_data, so that's not different from passing
hw_pci as we do today.

	Arnd

  reply	other threads:[~2014-02-13 12:21 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12 20:16 [PATCH v2 0/3] ARM: PCI: implement generic PCI host controller Will Deacon
2014-02-12 20:16 ` Will Deacon
2014-02-12 20:16 ` [PATCH v2 1/3] ARM: mach-virt: allow PCI support to be selected Will Deacon
2014-02-12 20:16   ` Will Deacon
2014-02-12 20:16 ` [PATCH v2 2/3] ARM: bios32: use pci_enable_resource to enable PCI resources Will Deacon
2014-02-12 20:16   ` Will Deacon
2014-02-12 22:28   ` Jason Gunthorpe
2014-02-12 22:28     ` Jason Gunthorpe
2014-02-13 10:06     ` Will Deacon
2014-02-13 10:06       ` Will Deacon
2014-02-13 12:22   ` Jingoo Han
2014-02-13 12:22     ` Jingoo Han
2014-02-12 20:16 ` [PATCH v2 3/3] PCI: ARM: add support for generic PCI host controller Will Deacon
2014-02-12 20:16   ` Will Deacon
2014-02-12 20:59   ` Arnd Bergmann
2014-02-12 20:59     ` Arnd Bergmann
2014-02-13 11:04     ` Will Deacon
2014-02-13 11:04       ` Will Deacon
2014-02-13 11:47       ` Arnd Bergmann
2014-02-13 11:47         ` Arnd Bergmann
2014-02-13 12:00         ` Will Deacon
2014-02-13 12:00           ` Will Deacon
2014-02-13 12:21           ` Arnd Bergmann [this message]
2014-02-13 12:21             ` Arnd Bergmann
2014-02-12 21:51   ` Kumar Gala
2014-02-12 21:51     ` Kumar Gala
2014-02-13 11:07     ` Will Deacon
2014-02-13 11:07       ` Will Deacon
2014-02-13 16:22       ` Kumar Gala
2014-02-13 16:22         ` Kumar Gala
2014-02-13 16:25         ` Will Deacon
2014-02-13 16:25           ` Will Deacon
2014-02-13 16:28         ` Arnd Bergmann
2014-02-13 16:28           ` Arnd Bergmann
2014-02-13 18:11           ` Mark Rutland
2014-02-13 18:11             ` Mark Rutland
2014-02-13 18:11             ` Mark Rutland
2014-02-13 18:26           ` Jason Gunthorpe
2014-02-13 18:26             ` Jason Gunthorpe
2014-02-13 19:53             ` Will Deacon
2014-02-13 19:53               ` Will Deacon
2014-02-13 20:20               ` Jason Gunthorpe
2014-02-13 20:20                 ` Jason Gunthorpe
2014-02-14  9:59               ` Arnd Bergmann
2014-02-14  9:59                 ` Arnd Bergmann
2014-02-14 22:00                 ` Liviu Dudau
2014-02-14 22:00                   ` Liviu Dudau
2014-02-15 13:03                   ` Arnd Bergmann
2014-02-15 13:03                     ` Arnd Bergmann
2014-02-18 17:41                     ` Jason Gunthorpe
2014-02-18 17:41                       ` Jason Gunthorpe
2014-02-18 18:25                       ` Arnd Bergmann
2014-02-18 18:25                         ` Arnd Bergmann
2014-02-18 18:45                         ` Jason Gunthorpe
2014-02-18 18:45                           ` Jason Gunthorpe
2014-02-18 19:13                           ` Arnd Bergmann
2014-02-18 19:13                             ` Arnd Bergmann
2014-02-19  2:44                       ` Liviu Dudau
2014-02-19  2:44                         ` Liviu Dudau
2014-02-19  6:48                         ` Jason Gunthorpe
2014-02-19  6:48                           ` Jason Gunthorpe
2014-02-19 10:24                         ` Arnd Bergmann
2014-02-19 10:24                           ` Arnd Bergmann
2014-02-19 11:37                           ` Liviu Dudau
2014-02-19 11:37                             ` Liviu Dudau
2014-02-19 13:26                             ` Arnd Bergmann
2014-02-19 13:26                               ` Arnd Bergmann
2014-02-19 15:30                               ` Liviu Dudau
2014-02-19 15:30                                 ` Liviu Dudau
2014-02-19 19:47                                 ` Arnd Bergmann
2014-02-19 19:47                                   ` Arnd Bergmann
2014-02-19  0:28                     ` Bjorn Helgaas
2014-02-19  0:28                       ` Bjorn Helgaas
2014-02-19  9:58                       ` Arnd Bergmann
2014-02-19  9:58                         ` Arnd Bergmann
2014-02-19 18:20                         ` Bjorn Helgaas
2014-02-19 18:20                           ` Bjorn Helgaas
2014-02-19 19:06                           ` Arnd Bergmann
2014-02-19 19:06                             ` Arnd Bergmann
2014-02-19 20:18                             ` Bjorn Helgaas
2014-02-19 20:18                               ` Bjorn Helgaas
2014-02-19 20:48                               ` Arnd Bergmann
2014-02-19 20:48                                 ` Arnd Bergmann
2014-02-19 21:10                                 ` Jason Gunthorpe
2014-02-19 21:10                                   ` Jason Gunthorpe
2014-02-19 21:33                                 ` Bjorn Helgaas
2014-02-19 21:33                                   ` Bjorn Helgaas
2014-02-19 22:12                                   ` Arnd Bergmann
2014-02-19 22:12                                     ` Arnd Bergmann
2014-02-19 22:18                                     ` Bjorn Helgaas
2014-02-19 22:18                                       ` Bjorn Helgaas
2014-02-13 19:52         ` Rob Herring
2014-02-13 19:52           ` Rob Herring
2014-02-13 18:06       ` Jason Gunthorpe
2014-02-13 18:06         ` Jason Gunthorpe
2014-02-13 19:51         ` Will Deacon
2014-02-13 19:51           ` Will Deacon
2014-02-13 18:26 ` [PATCH v2 0/3] ARM: PCI: implement " Jason Gunthorpe
2014-02-13 18:26   ` Jason Gunthorpe
2014-02-14 11:05   ` Arnd Bergmann
2014-02-14 11:05     ` Arnd Bergmann
2014-02-18 18:00     ` Jason Gunthorpe
2014-02-18 18:00       ` Jason Gunthorpe
2014-02-18 18:40       ` Arnd Bergmann
2014-02-18 18:40         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4122896.snWHKCSulY@wuerfel \
    --to=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.