All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Seyfried <seife@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Pavel Machek <pavel@suse.cz>
Subject: swsusp: avoid emergency disk parking in "platform" mode
Date: Fri, 20 Aug 2004 09:50:37 +0200	[thread overview]
Message-ID: <4125AD4D.7090102@suse.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

Hi,

although the issue seems fixed on normal shutdown and with swsusp in
"shutdown" mode, i still get the ugly "clunk" of my emergency-parking
disk in platform mode.
The attached patch fixes this for me, although i am not sure this is the
correct way to do. Probably some device_suspend(SOMETHING) would be
better and maybe the device_power_down is no longer needed, but
something needs to be done at this point.

   Stefan

[-- Attachment #2: platform_device_shutdown.diff --]
[-- Type: text/x-patch, Size: 418 bytes --]

diff -ru --exclude '*.o' linux-orig/kernel/power/disk.c linux/kernel/power/disk.c
--- linux-orig/kernel/power/disk.c	2004-08-17 19:56:33.000000000 +0200
+++ linux/kernel/power/disk.c	2004-08-20 09:40:40.581304056 +0200
@@ -49,6 +49,7 @@
 	local_irq_save(flags);
 	switch(mode) {
 	case PM_DISK_PLATFORM:
+		device_shutdown();
 		device_power_down(PM_SUSPEND_DISK);
 		error = pm_ops->enter(PM_SUSPEND_DISK);
 		break;

                 reply	other threads:[~2004-08-20  8:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4125AD4D.7090102@suse.de \
    --to=seife@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.