* swsusp: avoid emergency disk parking in "platform" mode
@ 2004-08-20 7:50 Stefan Seyfried
0 siblings, 0 replies; only message in thread
From: Stefan Seyfried @ 2004-08-20 7:50 UTC (permalink / raw)
To: linux-kernel; +Cc: Pavel Machek
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
Hi,
although the issue seems fixed on normal shutdown and with swsusp in
"shutdown" mode, i still get the ugly "clunk" of my emergency-parking
disk in platform mode.
The attached patch fixes this for me, although i am not sure this is the
correct way to do. Probably some device_suspend(SOMETHING) would be
better and maybe the device_power_down is no longer needed, but
something needs to be done at this point.
Stefan
[-- Attachment #2: platform_device_shutdown.diff --]
[-- Type: text/x-patch, Size: 418 bytes --]
diff -ru --exclude '*.o' linux-orig/kernel/power/disk.c linux/kernel/power/disk.c
--- linux-orig/kernel/power/disk.c 2004-08-17 19:56:33.000000000 +0200
+++ linux/kernel/power/disk.c 2004-08-20 09:40:40.581304056 +0200
@@ -49,6 +49,7 @@
local_irq_save(flags);
switch(mode) {
case PM_DISK_PLATFORM:
+ device_shutdown();
device_power_down(PM_SUSPEND_DISK);
error = pm_ops->enter(PM_SUSPEND_DISK);
break;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-08-20 8:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-20 7:50 swsusp: avoid emergency disk parking in "platform" mode Stefan Seyfried
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.