Re: [PATCH] Change alsamixer to show different views. Playback controls, or Capture controls.

[James Courtier-Dutton <James@superbug.demon.co.uk>]

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

Takashi Iwai wrote:
> At Fri, 27 Aug 2004 18:34:21 +0100,
> James Courtier-Dutton wrote:
> 
>>Takashi Iwai wrote:
>>
>>>>I have a question. The "Mic Boost" seems to think it is a "Playback" 
>>>>control. What would be the best way to getting that to be a "Capture" 
>>>>control. Would simply editing it in ac97_codec.c be enough?
>>>
>>>
>>>Hmm, when you change the control name itself, it breaks slightly
>>>compatibility with older version.
>>
>>What does the name have to be compatible with?
>>I.e. What program might break if we change this in ac97_codec.c ?
> 
> 
> Dunno.  But, at least, when you run "alsactl restore", the status
> won't be restored.
> 
> 
> Takashi
> 
> 

Thats true, but from a purely conceptual point of view, I think the Mic 
Boost should be associated with Capture and not associated with Playback.

I attach a patch to do just that.

James


[-- Attachment #2: mic-boost.diff.txt --]
[-- Type: text/plain, Size: 785 bytes --]

Index: alsa-driver/alsa-kernel/pci/ac97/ac97_codec.c
===================================================================
RCS file: /cvsroot/alsa/alsa-kernel/pci/ac97/ac97_codec.c,v
retrieving revision 1.144
diff -u -r1.144 ac97_codec.c
--- alsa-driver/alsa-kernel/pci/ac97/ac97_codec.c	11 Aug 2004 18:51:58 -0000	1.144
+++ alsa-driver/alsa-kernel/pci/ac97/ac97_codec.c	27 Aug 2004 21:10:44 -0000
@@ -687,7 +687,7 @@
 static const snd_kcontrol_new_t snd_ac97_controls_mic[3] = {
 AC97_SINGLE("Mic Playback Switch", AC97_MIC, 15, 1, 1),
 AC97_SINGLE("Mic Playback Volume", AC97_MIC, 0, 15, 1),
-AC97_SINGLE("Mic Boost (+20dB)", AC97_MIC, 6, 1, 0)
+AC97_SINGLE("Mic Boost (+20dB) Capture Switch", AC97_MIC, 6, 1, 0)
 };
 
 static const snd_kcontrol_new_t snd_ac97_control_capture_src = {