* RE: [PATCH] scsi: ufs: core: Remove unused field in struct ufs_hba
2022-03-24 7:01 ` [PATCH] scsi: ufs: core: Remove unused field in struct ufs_hba Keoseong Park
@ 2022-03-24 9:08 ` Avri Altman
2022-03-24 12:44 ` Bart Van Assche
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Avri Altman @ 2022-03-24 9:08 UTC (permalink / raw)
To: keosung.park@samsung.com, ALIM AKHTAR, jejb@linux.ibm.com,
martin.petersen@oracle.com, bvanassche@acm.org,
beanhuo@micron.com, Daejun Park, adrian.hunter@intel.com,
cang@codeaurora.org, asutoshd@codeaurora.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
> Remove unused field "rpm_lvl_attr" and "spm_lvl_attr" in struct ufs_hba.
> Commit cbb6813ee771 ("scsi: ufs: sysfs: attribute group for existing sysfs
> entries.") removed all code using that field.
>
> Signed-off-by: Keoseong Park <keosung.park@samsung.com>
Acked-by: Avri Altman <avri.altman@wdc.com>
> ---
> drivers/scsi/ufs/ufshcd.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h index
> 88c20f3608c2..94f545be183a 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -820,8 +820,6 @@ struct ufs_hba {
> enum ufs_pm_level rpm_lvl;
> /* Desired UFS power management level during system PM */
> enum ufs_pm_level spm_lvl;
> - struct device_attribute rpm_lvl_attr;
> - struct device_attribute spm_lvl_attr;
> int pm_op_in_progress;
>
> /* Auto-Hibernate Idle Timer register value */
> --
> 2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] scsi: ufs: core: Remove unused field in struct ufs_hba
2022-03-24 7:01 ` [PATCH] scsi: ufs: core: Remove unused field in struct ufs_hba Keoseong Park
2022-03-24 9:08 ` Avri Altman
@ 2022-03-24 12:44 ` Bart Van Assche
2022-03-30 3:28 ` Martin K. Petersen
2022-04-07 13:35 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Bart Van Assche @ 2022-03-24 12:44 UTC (permalink / raw)
To: keosung.park, ALIM AKHTAR, avri.altman@wdc.com,
jejb@linux.ibm.com, martin.petersen@oracle.com,
beanhuo@micron.com, Daejun Park, adrian.hunter@intel.com,
cang@codeaurora.org, asutoshd@codeaurora.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
On 3/24/22 00:01, Keoseong Park wrote:
> Remove unused field "rpm_lvl_attr" and "spm_lvl_attr" in struct ufs_hba.
> Commit cbb6813ee771 ("scsi: ufs: sysfs: attribute group for existing
> sysfs entries.") removed all code using that field.
>
> Signed-off-by: Keoseong Park <keosung.park@samsung.com>
> ---
> drivers/scsi/ufs/ufshcd.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index 88c20f3608c2..94f545be183a 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -820,8 +820,6 @@ struct ufs_hba {
> enum ufs_pm_level rpm_lvl;
> /* Desired UFS power management level during system PM */
> enum ufs_pm_level spm_lvl;
> - struct device_attribute rpm_lvl_attr;
> - struct device_attribute spm_lvl_attr;
> int pm_op_in_progress;
>
> /* Auto-Hibernate Idle Timer register value */
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] scsi: ufs: core: Remove unused field in struct ufs_hba
2022-03-24 7:01 ` [PATCH] scsi: ufs: core: Remove unused field in struct ufs_hba Keoseong Park
2022-03-24 9:08 ` Avri Altman
2022-03-24 12:44 ` Bart Van Assche
@ 2022-03-30 3:28 ` Martin K. Petersen
2022-04-07 13:35 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2022-03-30 3:28 UTC (permalink / raw)
To: Keoseong Park
Cc: ALIM AKHTAR, avri.altman@wdc.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, bvanassche@acm.org,
beanhuo@micron.com, Daejun Park, adrian.hunter@intel.com,
cang@codeaurora.org, asutoshd@codeaurora.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Keoseong,
> Remove unused field "rpm_lvl_attr" and "spm_lvl_attr" in struct
> ufs_hba. Commit cbb6813ee771 ("scsi: ufs: sysfs: attribute group for
> existing sysfs entries.") removed all code using that field.
Applied to 5.18/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] scsi: ufs: core: Remove unused field in struct ufs_hba
2022-03-24 7:01 ` [PATCH] scsi: ufs: core: Remove unused field in struct ufs_hba Keoseong Park
` (2 preceding siblings ...)
2022-03-30 3:28 ` Martin K. Petersen
@ 2022-04-07 13:35 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2022-04-07 13:35 UTC (permalink / raw)
To: linux-scsi; +Cc: Martin K . Petersen
On Thu, 24 Mar 2022 16:01:46 +0900, Keoseong Park wrote:
> Remove unused field "rpm_lvl_attr" and "spm_lvl_attr" in struct ufs_hba.
> Commit cbb6813ee771 ("scsi: ufs: sysfs: attribute group for existing
> sysfs entries.") removed all code using that field.
>
>
Applied to 5.18/scsi-fixes, thanks!
[1/1] scsi: ufs: core: Remove unused field in struct ufs_hba
https://git.kernel.org/mkp/scsi/c/8ee15ea779c3
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread