Fix for u32 match, problems when parsing arguments

Fix for u32 match, problems when parsing arguments

[Piotr Gasidło]

[-- Attachment #1.1: Type: text/plain, Size: 429 bytes --]

Hello,

I've found bug in u32 iptables helper library.

# iptables -A FORWARD -m u32 --u32 "0&0xffffffff=0"
iptables v1.2.11: u32: at char 2 error reading number

Attached patch, fixes problem.

-- 
Piotr 'QuakeR' Gasidło, BOFH @ pandora.barbara.eu.org
############## sending lusers to /dev/null since 1998
##### Waiting for tomorrow, for a little ray of light
### Waiting for tomorrow just to see your smile again

[-- Attachment #1.2: libipt_u32_fix.diff --]
[-- Type: text/plain, Size: 432 bytes --]

diff -uNr iptables.orig/extensions/libipt_u32.c iptables/extensions/libipt_u32.c
--- iptables.orig/extensions/libipt_u32.c	Thu Sep  2 14:13:50 2004
+++ iptables/extensions/libipt_u32.c	Thu Sep  2 13:20:23 2004
@@ -85,7 +85,7 @@
 	char *end;
 	errno = 0;
 
-	number = strtol(*s, &end, 0);
+	number = strtoul(*s, &end, 0);
 	if (end == *s)
 		exit_error(PARAMETER_PROBLEM, 
 			   "u32: at char %d expected number", pos);

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 232 bytes --]

Re: Fix for u32 match, problems when parsing arguments

[Patrick McHardy]

Piotr Gasid³o wrote:

>Hello,
>
>I've found bug in u32 iptables helper library.
>
># iptables -A FORWARD -m u32 --u32 "0&0xffffffff=0"
>iptables v1.2.11: u32: at char 2 error reading number
>  
>
>Attached patch, fixes problem.
>  
>
Applied, thanks.

Regards
Patrick

>  
>
>------------------------------------------------------------------------
>
>diff -uNr iptables.orig/extensions/libipt_u32.c iptables/extensions/libipt_u32.c
>--- iptables.orig/extensions/libipt_u32.c	Thu Sep  2 14:13:50 2004
>+++ iptables/extensions/libipt_u32.c	Thu Sep  2 13:20:23 2004
>@@ -85,7 +85,7 @@
> 	char *end;
> 	errno = 0;
> 
>-	number = strtol(*s, &end, 0);
>+	number = strtoul(*s, &end, 0);
> 	if (end == *s)
> 		exit_error(PARAMETER_PROBLEM, 
> 			   "u32: at char %d expected number", pos);
>  
>