From: Patrick McHardy <kaber@trash.net>
To: Phil Oester <netfilter@linuxace.com>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] kernel panic with rpc.patch
Date: Fri, 03 Sep 2004 03:52:13 +0200 [thread overview]
Message-ID: <4137CE4D.7070702@trash.net> (raw)
In-Reply-To: <20040902232357.GA18422@linuxace.com>
Phil Oester wrote:
>Some useless __MOD_INC_USE_COUNT macros make rpc patch panic on boot.
>The below removes them. Boot tested.
>
>This fixes bugzilla #50
>
>
Applied, but wondering on second thought. There are still two
__MOD_DEC_USE_COUNT left, and __MOD_INC_USE_COUNT does actually
do something :) Why are they useless ?
Regards
Patrick
>
>
>Phil
>
>
>
>
>------------------------------------------------------------------------
>
>diff -ru pom-orig/rpc/linux/net/ipv4/netfilter/ipt_rpc.c pom-new/rpc/linux/net/ipv4/netfilter/ipt_rpc.c
>--- pom-orig/rpc/linux/net/ipv4/netfilter/ipt_rpc.c 2003-12-18 13:48:00.000000000 -0500
>+++ pom-new/rpc/linux/net/ipv4/netfilter/ipt_rpc.c 2004-09-02 19:09:56.599859208 -0400
>@@ -394,10 +394,6 @@
> {
> int port;
>
>- DEBUGP("incrementing usage counts\n");
>- __MOD_INC_USE_COUNT(ip_conntrack_rpc_udp);
>- __MOD_INC_USE_COUNT(ip_conntrack_rpc_tcp);
>-
> /* If no port given, default to standard RPC port */
> if (ports[0] == 0)
> ports[0] = RPC_PORT;
>
>
next prev parent reply other threads:[~2004-09-03 1:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-02 23:23 [PATCH] kernel panic with rpc.patch Phil Oester
2004-09-03 1:52 ` Patrick McHardy [this message]
2004-09-03 4:21 ` Phil Oester
2004-09-03 16:15 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4137CE4D.7070702@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=netfilter@linuxace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.