From: Patrick McHardy <kaber@trash.net>
To: Phil Oester <kernel@linuxace.com>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] kernel panic with rpc.patch
Date: Fri, 03 Sep 2004 18:15:52 +0200 [thread overview]
Message-ID: <413898B8.6080406@trash.net> (raw)
In-Reply-To: <20040903042113.GA19923@linuxace.com>
Phil Oester wrote:
>On Fri, Sep 03, 2004 at 03:52:13AM +0200, Patrick McHardy wrote:
>
>>Applied, but wondering on second thought. There are still two
>>__MOD_DEC_USE_COUNT left, and __MOD_INC_USE_COUNT does actually
>>do something :) Why are they useless ?
>>
>>
>
>Yes, perhaps 'useless' is the wrong word -- they do something, but
>something which is deprecated and in 2.6 netfilter nonexistent. And
>following davem's policy of no refcounts for network drivers [1], it
>seems to make sense.
>
>Agreed, however, that removing the INC without also removing the DEC
>is sloppy. Attached find a patch to do so.
>
>
Thanks, applied.
Regards
Patrick
prev parent reply other threads:[~2004-09-03 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-02 23:23 [PATCH] kernel panic with rpc.patch Phil Oester
2004-09-03 1:52 ` Patrick McHardy
2004-09-03 4:21 ` Phil Oester
2004-09-03 16:15 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=413898B8.6080406@trash.net \
--to=kaber@trash.net \
--cc=kernel@linuxace.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.