Re: [PATCH] Re: boot time, process start time, and NOW time

[George Anzinger <george@mvista.com>]

OGAWA Hirofumi wrote:
> George Anzinger <george@mvista.com> writes:
> 
> 
>>>The cause of this is
>>>     INITIAL_JIFFIES % HZ (4294667296 % 1000)
>>>because INITIAL_JIFFIES is unsigned long.
>>>So, I guessed this is not intention.
>>>Looks like this should be (-300*1000) % 1000.
>>
>>What "should be"?
> 
> 
> in time_init(), and hpet_time_init(),
>         xtime.tv_nsec = (INITIAL_JIFFIES % HZ) * (NSEC_PER_SEC / HZ);
> should be
>         xtime.tv_nsec = ((long)INITIAL_JIFFIES % HZ) * (NSEC_PER_SEC / HZ);
> 
> because
> 	(INITIAL_JIFFIES % HZ) * (NSEC_PER_SEC / HZ)		== 296000000
> and
> 	((long)INITIAL_JIFFIES % HZ) * (NSEC_PER_SEC / HZ)	== 0

It is possible that I am missing something here, but I just don't see that it 
matters.  If the wall clock is set jiffies is not changed so there is no implied 
or actual alignment between these two.

Is there a calculation in the system that would differ if this were changed?

-- 
George Anzinger   george@mvista.com
High-res-timers:  http://sourceforge.net/projects/high-res-timers/
Preemption patch: http://www.kernel.org/pub/linux/kernel/people/rml