All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Kees Cook <keescook@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Laura Abbott <laura@labbott.name>,
	Mark Rutland <mark.rutland@arm.com>,
	Jeremy Linton <jeremy.linton@arm.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	kernel-hardening@lists.openwall.com,
	linux-kernel@vger.kernel.org
Subject: [kernel-hardening] Re: [PATCH] lkdtm: add test for executing .rodata
Date: Wed, 17 Feb 2016 22:44:12 +0100	[thread overview]
Message-ID: <4143845.Jr27FPv8XS@wuerfel> (raw)
In-Reply-To: <20160216214904.GA23723@www.outflux.net>

On Tuesday 16 February 2016 13:49:04 Kees Cook wrote:
>  }
>  
> +static void __attribute__((__section__(".rodata,\"a\",@progbits#")))
> +do_nothing_rodata(void)
> +{
> +       return;
> +}
> +
>  static void do_nothing(void)
>  {
> 

I think this also needs to be marked "noinline" to ensure that the
function does not get eliminated. I've seen clang do that on
execute_location() recently and submitted a patch for that.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Kees Cook <keescook@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Laura Abbott <laura@labbott.name>,
	Mark Rutland <mark.rutland@arm.com>,
	Jeremy Linton <jeremy.linton@arm.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	kernel-hardening@lists.openwall.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lkdtm: add test for executing .rodata
Date: Wed, 17 Feb 2016 22:44:12 +0100	[thread overview]
Message-ID: <4143845.Jr27FPv8XS@wuerfel> (raw)
In-Reply-To: <20160216214904.GA23723@www.outflux.net>

On Tuesday 16 February 2016 13:49:04 Kees Cook wrote:
>  }
>  
> +static void __attribute__((__section__(".rodata,\"a\",@progbits#")))
> +do_nothing_rodata(void)
> +{
> +       return;
> +}
> +
>  static void do_nothing(void)
>  {
> 

I think this also needs to be marked "noinline" to ensure that the
function does not get eliminated. I've seen clang do that on
execute_location() recently and submitted a patch for that.

	Arnd

  parent reply	other threads:[~2016-02-17 21:44 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-16 21:49 [kernel-hardening] [PATCH] lkdtm: add test for executing .rodata Kees Cook
2016-02-16 21:49 ` Kees Cook
2016-02-17  1:06 ` [kernel-hardening] " Laura Abbott
2016-02-17  1:06   ` Laura Abbott
2016-02-17 20:29   ` [kernel-hardening] " Kees Cook
2016-02-17 20:29     ` Kees Cook
2016-02-17 21:06     ` [kernel-hardening] " Kees Cook
2016-02-17 21:06       ` Kees Cook
2016-02-18 10:32     ` [kernel-hardening] " PaX Team
2016-02-18 10:32       ` PaX Team
2016-02-18 11:34       ` [kernel-hardening] " Ard Biesheuvel
2016-02-18 11:34         ` Ard Biesheuvel
2016-02-18 11:55         ` [kernel-hardening] " Ard Biesheuvel
2016-02-18 11:55           ` Ard Biesheuvel
2016-02-18 12:07         ` [kernel-hardening] " Arnd Bergmann
2016-02-18 12:07           ` Arnd Bergmann
2016-02-18 12:46           ` [kernel-hardening] " Ard Biesheuvel
2016-02-18 12:46             ` Ard Biesheuvel
2016-02-18 20:04             ` [kernel-hardening] " Kees Cook
2016-02-18 20:04               ` Kees Cook
2016-02-18 21:27         ` [kernel-hardening] " PaX Team
2016-02-18 21:27           ` PaX Team
2016-02-22 20:46           ` [kernel-hardening] " Kees Cook
2016-02-22 20:46             ` Kees Cook
2016-02-22 23:21             ` [kernel-hardening] " PaX Team
2016-02-22 23:21               ` PaX Team
2016-02-23 20:53               ` [kernel-hardening] " Kees Cook
2016-02-23 20:53                 ` Kees Cook
2016-02-23 22:00                 ` [kernel-hardening] " PaX Team
2016-02-23 22:00                   ` PaX Team
2016-02-23 22:02                   ` [kernel-hardening] " Kees Cook
2016-02-23 22:02                     ` Kees Cook
2016-02-23 20:31             ` [kernel-hardening] " David Brown
2016-02-23 20:51               ` Kees Cook
2016-02-17 21:44 ` Arnd Bergmann [this message]
2016-02-17 21:44   ` Arnd Bergmann
2016-02-17 21:45   ` [kernel-hardening] " Arnd Bergmann
2016-02-17 21:45     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4143845.Jr27FPv8XS@wuerfel \
    --to=arnd@arndb.de \
    --cc=ard.biesheuvel@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeremy.linton@arm.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=laura@labbott.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.