From: Sylvain Munaut <tnt@246tNt.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux PPC Dev <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 10/9] Small updates for Freescale MPC52xx - Late one ...
Date: Wed, 15 Sep 2004 22:46:44 +0200 [thread overview]
Message-ID: <4148AA34.3000003@246tNt.com> (raw)
In-Reply-To: <4146D833.8040703@246tNt.com>
Hello
Sorry for this late one, I just got it and it belongs with the others.
I've added it to the bk tree I sent earlier (
bk://bkbits.246tNt.com/linux-2.5-mpc52xx-pending )
so please pull from that tree.
The unified diff along with the patch description is below.
Thanks,
Sylvain
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/09/15 22:03:38+02:00 tnt@246tNt.com
# ppc: Fix output of low-level serial debug on Freescale MPC52xx
#
# Thanks to Roger Blofeld for pointing that out.
#
# Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
#
# arch/ppc/syslib/mpc52xx_setup.c
# 2004/09/15 22:02:23+02:00 tnt@246tNt.com +14 -10
# ppc: Fix output of low-level serial debug on Freescale MPC52xx
#
diff -Nru a/arch/ppc/syslib/mpc52xx_setup.c
b/arch/ppc/syslib/mpc52xx_setup.c
--- a/arch/ppc/syslib/mpc52xx_setup.c 2004-09-15 22:36:07 +02:00
+++ b/arch/ppc/syslib/mpc52xx_setup.c 2004-09-15 22:36:07 +02:00
@@ -100,24 +100,28 @@
#error "mpc52xx PSC for console not selected"
#endif
+static void
+mpc52xx_psc_putc(struct mpc52xx_psc * psc, unsigned char c)
+{
+ while (!(in_be16(&psc->mpc52xx_psc_status) &
+ MPC52xx_PSC_SR_TXRDY));
+ out_8(&psc->mpc52xx_psc_buffer_8, c);
+}
+
void
mpc52xx_progress(char *s, unsigned short hex)
{
struct mpc52xx_psc *psc = (struct mpc52xx_psc *)MPC52xx_CONSOLE;
char c;
- /* Don't we need to disable serial interrupts ? */
-
while ((c = *s++) != 0) {
- if (c == '\n') {
- while (!(in_be16(&psc->mpc52xx_psc_status) &
- MPC52xx_PSC_SR_TXRDY)) ;
- out_8(&psc->mpc52xx_psc_buffer_8, '\r');
- }
- while (!(in_be16(&psc->mpc52xx_psc_status) &
- MPC52xx_PSC_SR_TXRDY)) ;
- out_8(&psc->mpc52xx_psc_buffer_8, c);
+ if (c == '\n')
+ mpc52xx_psc_putc(psc, '\r');
+ mpc52xx_psc_putc(psc, c);
}
+
+ mpc52xx_psc_putc(psc, '\r');
+ mpc52xx_psc_putc(psc, '\n');
}
#endif /* CONFIG_SERIAL_TEXT_DEBUG */
WARNING: multiple messages have this Message-ID (diff)
From: Sylvain Munaut <tnt@246tNt.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Linux PPC Dev <linuxppc-dev@ozlabs.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Paul Mackerras <paulus@samba.org>
Subject: [PATCH 10/9] Small updates for Freescale MPC52xx - Late one ...
Date: Wed, 15 Sep 2004 22:46:44 +0200 [thread overview]
Message-ID: <4148AA34.3000003@246tNt.com> (raw)
In-Reply-To: <4146D833.8040703@246tNt.com>
Hello
Sorry for this late one, I just got it and it belongs with the others.
I've added it to the bk tree I sent earlier (
bk://bkbits.246tNt.com/linux-2.5-mpc52xx-pending )
so please pull from that tree.
The unified diff along with the patch description is below.
Thanks,
Sylvain
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/09/15 22:03:38+02:00 tnt@246tNt.com
# ppc: Fix output of low-level serial debug on Freescale MPC52xx
#
# Thanks to Roger Blofeld for pointing that out.
#
# Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
#
# arch/ppc/syslib/mpc52xx_setup.c
# 2004/09/15 22:02:23+02:00 tnt@246tNt.com +14 -10
# ppc: Fix output of low-level serial debug on Freescale MPC52xx
#
diff -Nru a/arch/ppc/syslib/mpc52xx_setup.c
b/arch/ppc/syslib/mpc52xx_setup.c
--- a/arch/ppc/syslib/mpc52xx_setup.c 2004-09-15 22:36:07 +02:00
+++ b/arch/ppc/syslib/mpc52xx_setup.c 2004-09-15 22:36:07 +02:00
@@ -100,24 +100,28 @@
#error "mpc52xx PSC for console not selected"
#endif
+static void
+mpc52xx_psc_putc(struct mpc52xx_psc * psc, unsigned char c)
+{
+ while (!(in_be16(&psc->mpc52xx_psc_status) &
+ MPC52xx_PSC_SR_TXRDY));
+ out_8(&psc->mpc52xx_psc_buffer_8, c);
+}
+
void
mpc52xx_progress(char *s, unsigned short hex)
{
struct mpc52xx_psc *psc = (struct mpc52xx_psc *)MPC52xx_CONSOLE;
char c;
- /* Don't we need to disable serial interrupts ? */
-
while ((c = *s++) != 0) {
- if (c == '\n') {
- while (!(in_be16(&psc->mpc52xx_psc_status) &
- MPC52xx_PSC_SR_TXRDY)) ;
- out_8(&psc->mpc52xx_psc_buffer_8, '\r');
- }
- while (!(in_be16(&psc->mpc52xx_psc_status) &
- MPC52xx_PSC_SR_TXRDY)) ;
- out_8(&psc->mpc52xx_psc_buffer_8, c);
+ if (c == '\n')
+ mpc52xx_psc_putc(psc, '\r');
+ mpc52xx_psc_putc(psc, c);
}
+
+ mpc52xx_psc_putc(psc, '\r');
+ mpc52xx_psc_putc(psc, '\n');
}
#endif /* CONFIG_SERIAL_TEXT_DEBUG */
next prev parent reply other threads:[~2004-09-15 20:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-14 11:38 [PATCH 0/9] Small updates for Freescale MPC52xx Sylvain Munaut
2004-09-14 11:38 ` Sylvain Munaut
2004-09-14 11:46 ` [PATCH 1/9] " Sylvain Munaut
2004-09-14 11:46 ` Sylvain Munaut
2004-09-14 11:48 ` [PATCH 2/9] " Sylvain Munaut
2004-09-14 11:48 ` Sylvain Munaut
2004-09-14 11:50 ` [PATCH 3/9] " Sylvain Munaut
2004-09-14 11:50 ` Sylvain Munaut
2004-09-14 11:50 ` [PATCH 4/9] " Sylvain Munaut
2004-09-14 11:50 ` Sylvain Munaut
2004-09-14 11:54 ` [PATCH 5/9] " Sylvain Munaut
2004-09-14 11:54 ` Sylvain Munaut
2004-09-14 11:59 ` [PATCH 6/9] " Sylvain Munaut
2004-09-14 11:59 ` Sylvain Munaut
2004-09-14 12:00 ` [PATCH 7/9] " Sylvain Munaut
2004-09-14 12:00 ` Sylvain Munaut
2004-09-14 12:01 ` [PATCH 8/9] " Sylvain Munaut
2004-09-14 12:01 ` Sylvain Munaut
2004-09-14 12:02 ` [PATCH 9/9] " Sylvain Munaut
2004-09-14 12:02 ` Sylvain Munaut
2004-09-15 20:46 ` Sylvain Munaut [this message]
2004-09-15 20:46 ` [PATCH 10/9] Small updates for Freescale MPC52xx - Late one Sylvain Munaut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4148AA34.3000003@246tNt.com \
--to=tnt@246tnt.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.