From: Keith Whitwell <keith@tungstengraphics.com>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: [PATCH 2.6.9-rc2 3/33] char/drm_os_linux:
Date: Thu, 16 Sep 2004 07:09:49 +0000 [thread overview]
Message-ID: <41493C3D.6090403@tungstengraphics.com> (raw)
Nishanth Aravamudan wrote:
> Any comments would be appreciated.
>
> Description: Use set_current_state() instead of direct assignment of
> current->state.
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
>
> --- 2.6.9-rc1-mm4-vanilla/drivers/char/drm/drm_os_linux.h 2004-09-09 23:05:38.000000000 -0700
> +++ 2.6.9-rc1-mm4/drivers/char/drm/drm_os_linux.h 2004-09-10 10:34:04.000000000 -0700
> @@ -134,7 +134,7 @@ do { \
> add_wait_queue(&(queue), &entry); \
> \
> for (;;) { \
> - current->state = TASK_INTERRUPTIBLE; \
> + set_current_state(TASK_INTERRUPTIBLE); \
> if (condition) \
> break; \
> if (time_after_eq(jiffies, end)) { \
>
There are two assignments in that macro, aren't there? Why not adjust both of
them?
Keith
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2004-09-16 7:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-16 7:09 Keith Whitwell [this message]
2004-09-16 11:00 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 3/33] char/drm_os_linux: Dave Airlie
2004-09-16 12:03 ` Alan Cox
2004-09-18 16:44 ` Jon Smirl
2004-09-28 22:24 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 3/4] sbus/bbc_i2c: replace David S. Miller
2004-09-29 17:41 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 3/4] pci hotplug/pciehp: Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41493C3D.6090403@tungstengraphics.com \
--to=keith@tungstengraphics.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.