From: Jeff Garzik <jgarzik@pobox.com>
To: Andy Warner <andyw@pobox.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: WARN_ON(buflen > PAGE_SIZE) libata-core.c
Date: Thu, 16 Sep 2004 20:49:42 -0400 [thread overview]
Message-ID: <414A34A6.1020506@pobox.com> (raw)
In-Reply-To: <20040901150801.A12145@florence.linkmargin.com>
Andy Warner wrote:
> I'm working on a tree pulled directly from
> bk://gkernel.bkbits.net/libata-2.6
>
> In libata-core.c:ata_sg_init_one() there is:
>
> WARN_ON(buflen > PAGE_SIZE);
>
> Which (unsurpsingly) triggers for all non-tiny
> transfers (I'm using sg_utils to generate disk
> traffic.)
>
> It's obviously there for a reason, what would
> I need to do to get past it. Give me some background
> and maybe I can come up with a patch :)
A non-scatter-gather transfer is assumed to be one page in length, using
only a single 'struct scatterlist' element. You could probably "cheat"
and indicate the scatterlist element is longer than PAGE_SIZE, but make
sure to review all code paths...
Jeff
next prev parent reply other threads:[~2004-09-17 0:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-01 20:08 WARN_ON(buflen > PAGE_SIZE) libata-core.c Andy Warner
2004-09-17 0:49 ` Jeff Garzik [this message]
2004-09-17 2:34 ` Andy Warner
2004-09-17 2:39 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=414A34A6.1020506@pobox.com \
--to=jgarzik@pobox.com \
--cc=andyw@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.