From: Jeff Garzik <jgarzik@pobox.com>
To: Andy Warner <andyw@pobox.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: WARN_ON(buflen > PAGE_SIZE) libata-core.c
Date: Thu, 16 Sep 2004 22:39:34 -0400 [thread overview]
Message-ID: <414A4E66.5000009@pobox.com> (raw)
In-Reply-To: <20040916213450.A14950@florence.linkmargin.com>
Andy Warner wrote:
> Jeff Garzik wrote:
>
>>[...]
>>
>>>In libata-core.c:ata_sg_init_one() there is:
>>>
>>> WARN_ON(buflen > PAGE_SIZE);
>>
>>[...]
>>A non-scatter-gather transfer is assumed to be one page in length, using
>>only a single 'struct scatterlist' element. You could probably "cheat"
>>and indicate the scatterlist element is longer than PAGE_SIZE, but make
>>sure to review all code paths...
>
>
> Bear with me, if I'm being dense, but why is that a valid
> assumption ? Is it because in most instances, such requests
> are made by filesystem code, as opposed to arbitrary user
> initiated I/O ?
A struct scatterlist is a list of page/offset/length triplets, so it
breaks the model if a triplet extends past a page boundary.
Jeff
prev parent reply other threads:[~2004-09-17 2:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-01 20:08 WARN_ON(buflen > PAGE_SIZE) libata-core.c Andy Warner
2004-09-17 0:49 ` Jeff Garzik
2004-09-17 2:34 ` Andy Warner
2004-09-17 2:39 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=414A4E66.5000009@pobox.com \
--to=jgarzik@pobox.com \
--cc=andyw@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.