Re: [PATCH] convert mport to multiport

[Pablo Neira <pablo@eurodev.net>]

Hi Patrick,

Patrick McHardy wrote:

>>> +/* every entry in ports[] except for the last one has one bit in 
>>> pflags
>>> + * associated with it. If this bit is set, the port is the first 
>>> port of
>>> + * a portrange, with the next entry being the last.
>>> + * End of list is marked with pflags bit set and port=65535.
>>> + * If 14 ports are used (last one does not have a pflag), the last 
>>> port
>>> + * is repeated to fill the last entry in ports[] */
>>> struct ipt_multiport
>>> {
>>> -    u_int8_t flags;                /* Type of comparison */
>>> -    u_int8_t count;                /* Number of ports */
>>> +    u_int8_t flags:2;            /* Type of comparison */
>>> +    u_int16_t pflags:14;            /* Port flags */
>>>     u_int16_t ports[IPT_MULTI_PORTS];    /* Ports */
>>> +    u_int8_t count;                         /* Number of ports */
>>>  
>>>
>
> This breaks userspace compatibility. We can't do that, sorry.


In that case, I have the patches without that change here, I'll test 
them and then I'll resend them to you again.

regards,
Pablo