From: Greg Ungerer <gerg@snapgear.com>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: [PATCH 2.6.9-rc2 4/6] serial/mcfserial:
Date: Tue, 28 Sep 2004 00:32:15 +0000 [thread overview]
Message-ID: <4158B10F.5080100@snapgear.com> (raw)
In-Reply-To: <20040920215026.GK2270@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1977 bytes --]
Hi Nishanth,
Nishanth Aravamudan wrote:
> Any comments would be appreciated.
>
> Description: Use msleep_interruptible() instead of schedule_timeout() to
> guarantee the task delays as expected. Use set_current_state() instead
> of direct assignment of current->state.
Looks ok to me.
Regards
Greg
> --- 2.6.9-rc2-vanilla/drivers/serial/mcfserial.c 2004-09-13 17:15:52.000000000 -0700
> +++ 2.6.9-rc2/drivers/serial/mcfserial.c 2004-09-27 14:23:12.000000000 -0700
> @@ -34,6 +34,7 @@
> #include <linux/serialP.h>
> #include <linux/console.h>
> #include <linux/init.h>
> +#include <linux/delay.h>
>
> #include <asm/io.h>
> #include <asm/irq.h>
> @@ -997,7 +998,7 @@ static void send_break( struct mcf_seria
>
> if (!info->addr)
> return;
> - current->state = TASK_INTERRUPTIBLE;
> + set_current_state(TASK_INTERRUPTIBLE);
> uartp = info->addr;
>
> local_irq_save(flags);
> @@ -1247,8 +1248,7 @@ static void mcfrs_close(struct tty_struc
> }
> if (info->blocked_open) {
> if (info->close_delay) {
> - current->state = TASK_INTERRUPTIBLE;
> - schedule_timeout(info->close_delay);
> + msleep_interruptible(jiffies_to_msecs(info->close_delay));
> }
> wake_up_interruptible(&info->open_wait);
> }
> @@ -1313,8 +1313,7 @@ mcfrs_wait_until_sent(struct tty_struct
> fifo_cnt++;
> if (fifo_cnt == 0)
> break;
> - set_current_state(TASK_INTERRUPTIBLE);
> - schedule_timeout(char_time);
> + msleep_interruptible(jiffies_to_msecs(char_time));
> if (signal_pending(current))
> break;
> if (timeout && time_after(jiffies, orig_jiffies + timeout))
>
--
------------------------------------------------------------------------
Greg Ungerer -- Chief Software Dude EMAIL: gerg@snapgear.com
SnapGear -- a CyberGuard Company PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-09-28 0:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-20 21:50 [Kernel-janitors] Re: [PATCH 2.6.9-rc2 4/17] media/cx88-tvaudio: Nishanth Aravamudan
2004-09-21 18:06 ` maximilian attems
2004-09-28 0:32 ` Greg Ungerer [this message]
2004-09-28 15:24 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 4/9] usb/file_storage: Alan Stern
2004-09-29 17:41 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 4/4] pci hotplug/shpchp: Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4158B10F.5080100@snapgear.com \
--to=gerg@snapgear.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.