[Kernel-janitors] Re: [PATCH 2.6.9-rc2 4/17] media/cx88-tvaudio:

[Kernel-janitors] Re: [PATCH 2.6.9-rc2 4/17] media/cx88-tvaudio:

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

Sorry this should have been 5/17.

On Mon, Sep 20, 2004 at 02:50:02PM -0700, Nishanth Aravamudan wrote:
> Any comments would be appreciated.
> 
> Description: Use msleep_interruptible() instead of schedule_timeout() to
> guarantee the task delays as expected.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> 
> --- 2.6.9-rc1-mm4-vanilla/drivers/media/video/cx88/cx88-tvaudio.c	2004-09-09 23:05:26.000000000 -0700
> +++ 2.6.9-rc1-mm4/drivers/media/video/cx88/cx88-tvaudio.c	2004-09-13 14:26:23.000000000 -0700
> @@ -49,6 +49,7 @@
>  #include <linux/vmalloc.h>
>  #include <linux/init.h>
>  #include <linux/smp_lock.h>
> +#include <linux/delay.h>
>  
>  #include "cx88.h"
>  
> @@ -785,8 +786,7 @@ int cx88_audio_thread(void *data)
>  	dprintk("cx88: tvaudio thread started\n");
>  
>  	for (;;) {
> -		set_current_state(TASK_INTERRUPTIBLE);
> -		schedule_timeout(HZ*3);
> +		msleep_interruptible(3000);
>  		if (signal_pending(current))
>  			break;
>  		if (dev->shutdown)

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] Re: [PATCH 2.6.9-rc2 4/17] media/cx88-tvaudio:

[maximilian attems]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

On Mon, 20 Sep 2004, Nishanth Aravamudan wrote:

> Sorry this should have been 5/17.

you should try patch-scripts from akpm their patch-bomb automates this. ;)
-> http://www.zip.com.au/~akpm/linux/patches/

a++ maks
 

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] Re: [PATCH 2.6.9-rc2 4/6] serial/mcfserial:

[Greg Ungerer]

[-- Attachment #1: Type: text/plain, Size: 1977 bytes --]

Hi Nishanth,

Nishanth Aravamudan wrote:
> Any comments would be appreciated.
> 
> Description: Use msleep_interruptible() instead of schedule_timeout() to
> guarantee the task delays as expected. Use set_current_state() instead
> of direct assignment of current->state.

Looks ok to me.

Regards
Greg



> --- 2.6.9-rc2-vanilla/drivers/serial/mcfserial.c	2004-09-13 17:15:52.000000000 -0700
> +++ 2.6.9-rc2/drivers/serial/mcfserial.c	2004-09-27 14:23:12.000000000 -0700
> @@ -34,6 +34,7 @@
>  #include <linux/serialP.h>
>  #include <linux/console.h>
>  #include <linux/init.h>
> +#include <linux/delay.h>
>  
>  #include <asm/io.h>
>  #include <asm/irq.h>
> @@ -997,7 +998,7 @@ static void send_break(	struct mcf_seria
>  
>  	if (!info->addr)
>  		return;
> -	current->state = TASK_INTERRUPTIBLE;
> +	set_current_state(TASK_INTERRUPTIBLE);
>  	uartp = info->addr;
>  
>  	local_irq_save(flags);
> @@ -1247,8 +1248,7 @@ static void mcfrs_close(struct tty_struc
>  	}
>  	if (info->blocked_open) {
>  		if (info->close_delay) {
> -			current->state = TASK_INTERRUPTIBLE;
> -			schedule_timeout(info->close_delay);
> +			msleep_interruptible(jiffies_to_msecs(info->close_delay));
>  		}
>  		wake_up_interruptible(&info->open_wait);
>  	}
> @@ -1313,8 +1313,7 @@ mcfrs_wait_until_sent(struct tty_struct 
>  			fifo_cnt++;
>  		if (fifo_cnt == 0)
>  			break;
> -		set_current_state(TASK_INTERRUPTIBLE);
> -		schedule_timeout(char_time);
> +		msleep_interruptible(jiffies_to_msecs(char_time));
>  		if (signal_pending(current))
>  			break;
>  		if (timeout && time_after(jiffies, orig_jiffies + timeout))
> 

-- 
------------------------------------------------------------------------
Greg Ungerer  --  Chief Software Dude       EMAIL:     gerg@snapgear.com
SnapGear -- a CyberGuard Company            PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] Re: [PATCH 2.6.9-rc2 4/9] usb/file_storage:

[Alan Stern]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1008 bytes --]

On Mon, 27 Sep 2004, Nishanth Aravamudan wrote:

> Any comments would be appreciated.
> 
> Description: Use msleep_interruptible() instead of schedule_timeout()
> so that the task delays as expected.
> 
> --- 2.6.9-rc2-vanilla/drivers/usb/gadget/file_storage.c	2004-09-13 17:15:52.000000000 -0700
> +++ 2.6.9-rc2/drivers/usb/gadget/file_storage.c	2004-09-27 14:47:54.000000000 -0700
> @@ -217,6 +217,7 @@
>  #include <linux/compiler.h>
>  #include <linux/completion.h>
>  #include <linux/dcache.h>
> +#include <linux/delay.h>
>  #include <linux/device.h>
>  #include <linux/fcntl.h>
>  #include <linux/file.h>
> @@ -2280,8 +2281,7 @@ static int halt_bulk_in_endpoint(struct 
>  		}
>  
>  		/* Wait for a short time and then try again */
> -		set_current_state(TASK_INTERRUPTIBLE);
> -		if (schedule_timeout(HZ / 10) != 0)
> +		if (msleep_interruptible(100) != 0)
>  			return -EINTR;
>  		rc = usb_ep_set_halt(fsg->bulk_in);
>  	}

This change is okay.  Greg, you have my approval to apply it.

Alan Stern


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] Re: [PATCH 2.6.9-rc2 4/4] pci hotplug/shpchp:

[Greg KH]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

On Fri, Sep 24, 2004 at 04:20:38PM -0700, Nishanth Aravamudan wrote:
> Any comments would be appreciated.
> 
> Description: Use msleep_interruptible() instead of
> schedule_timeout() to guarantee the task delays as expected.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

Applied, thanks.

greg k-h


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors