[Kernel-janitors] Status of pci_find_device fixes

[Kernel-janitors] Status of pci_find_device fixes

[Tobias Klauser]

[-- Attachment #1: Type: text/plain, Size: 795 bytes --]

Hi

I saw this entry in the TODO list:

------------------------------------------------------------------------
From: Greg KH

- delete all pci_find_* functions from the kernel tree.
   Instead of pci_find_device use pci_get_device()..

 > Looking at pci.txt, it appears that if I use pci_get_device(), I will
 > also need to use pci_dev_put().
------------------------------------------------------------------------

Since I'm interested in the PCI section in the kernel (and Greg pointed 
me to that when I was bugging him ;), I thought this would be a good 
point to start helping. While crawling through the kernel-janitor 
archives I noticed, that there's already work ongoing on that issue.

What's the status of this and are there drivers which still need to be 
fixed?

Thanks, Tobias

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] Status of pci_find_device fixes

[Hanna Linder]

[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]

--On Wednesday, September 29, 2004 03:09:52 PM +0200 Tobias Klauser <tklauser@nuerscht.ch> wrote:
> 
> Since I'm interested in the PCI section in the kernel (and Greg pointed me to that when I was bugging him ;), I thought this would be a good point to start helping. While crawling through the
> kernel-janitor archives I noticed, that there's already work ongoing on that issue.
> 
> What's the status of this and are there drivers which still need to be fixed?

Hi Tobias,

Thanks for your interest. There are a couple of us working in this area already but if we all
coordinate it should help get the work done quickly. Scott is doing everything under drivers/net
to start with. Greg and I finished everything under arch/i386. Right now I am working on
all the drivers that can be converted to the new pci_dev_present function. That leaves over
100 drivers that need to be converted (cscope and grep are your friend).

If this sounds like something you are interested in feel free to jump in and make sure to
send you patches back to the list. If you want to make sure no one else is working on the 
same driver before you start that would be good. Use this list, that is what it is for. 

Hanna



[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] Status of pci_find_device fixes

[Scott Feldman]

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]

On Wed, 2004-09-29 at 11:15, Hanna Linder wrote:

> Thanks for your interest. There are a couple of us working in this area already but if we all
> coordinate it should help get the work done quickly. Scott is doing everything under drivers/net
> to start with. Greg and I finished everything under arch/i386. Right now I am working on
> all the drivers that can be converted to the new pci_dev_present function. That leaves over
> 100 drivers that need to be converted (cscope and grep are your friend).

driver/net is shaping up.  There are still a couple that need
probe/remove conversion.

I'm heading over to drivers/scsi next, FWIW.

-scott


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] Status of pci_find_device fixes

[Scott Feldman]

[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]

On Sun, 2004-10-03 at 20:43, Scott Feldman wrote:
> On Wed, 2004-09-29 at 11:15, Hanna Linder wrote:
> 
> > Thanks for your interest. There are a couple of us working in this area already but if we all
> > coordinate it should help get the work done quickly. Scott is doing everything under drivers/net
> > to start with. Greg and I finished everything under arch/i386. Right now I am working on
> > all the drivers that can be converted to the new pci_dev_present function. That leaves over
> > 100 drivers that need to be converted (cscope and grep are your friend).
> 
> driver/net is shaping up.  There are still a couple that need
> probe/remove conversion.
> 
> I'm heading over to drivers/scsi next, FWIW.

No low hanging fruit in SCSI orchards!  Looks like plenty of pci_driver
support missing:

# grep -l scsi_module.c `grep -l -r pci_find_device drivers/scsi/*`
drivers/scsi/3w-xxxx.c
drivers/scsi/advansys.c
drivers/scsi/aic7xxx_old.c
drivers/scsi/cpqfcTSinit.c
drivers/scsi/dmx3191d.c
drivers/scsi/eata_pio.c
drivers/scsi/fdomain.c
drivers/scsi/gdth.c
drivers/scsi/ini9100u.c
drivers/scsi/pci2000.c
drivers/scsi/pci2220i.c
drivers/scsi/qla1280.c
drivers/scsi/qlogicfc.c
drivers/scsi/qlogicisp.c

What's a good driver for reference that uses the "new-style" template?

-scott


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] Status of pci_find_device fixes

[Hanna Linder]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

--On Sunday, October 03, 2004 08:43:08 PM -0700 Scott Feldman <sfeldma@pobox.com> wrote:
> 
> driver/net is shaping up.  There are still a couple that need
> probe/remove conversion.
> 
> I'm heading over to drivers/scsi next, FWIW.
> 
> -scott
> 

Thanks Scott,

I just finished ia64 and am moving on to the other arch's.

Hanna




[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors