[Kernel-janitors] [PATCH 2.6.9-rc2-mm4 fore200e.c] convert

[Kernel-janitors] [PATCH 2.6.9-rc2-mm4 fore200e.c] convert

[Tobias Klauser]

[-- Attachment #1: Type: text/plain, Size: 915 bytes --]

I'm sending this only to kernel-janitor since I'm not sure, if I do this 
right (It's my first patch). It compiled without problems here.

Description: Use pci_get_device instead of pci_find_device.

Signed-off-by: Tobias Klauser <tklauser@nuerscht.ch>

diff -Nrup linux-2.6.9-rc2-mm4-vanilla/drivers/atm/fore200e.c 
linux-2.6.9-rc2-mm4/drivers/atm/fore200e.c
--- linux-2.6.9-rc2-mm4-vanilla/drivers/atm/fore200e.c  2004-09-30 
10:24:43.000000000 +0200
+++ linux-2.6.9-rc2-mm4/drivers/atm/fore200e.c  2004-09-30 
10:41:20.368794120 +0200
@@ -644,7 +644,7 @@ fore200e_pca_detect(const struct fore200
      int              count = index;

      do {
-       pci_dev = pci_find_device(PCI_VENDOR_ID_FORE, 
PCI_DEVICE_ID_FORE_PCA200E, pci_dev);
+       pci_dev = pci_get_device(PCI_VENDOR_ID_FORE, 
PCI_DEVICE_ID_FORE_PCA200E, pci_dev);
         if (pci_dev == NULL)
             return NULL;
      } while (count--);

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] [PATCH 2.6.9-rc2-mm4 fore200e.c] convert

[Christoph Hellwig]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

On Thu, Sep 30, 2004 at 11:29:48AM +0200, Tobias Klauser wrote:
> I'm sending this only to kernel-janitor since I'm not sure, if I do this 
> right (It's my first patch). It compiled without problems here.
> 
> Description: Use pci_get_device instead of pci_find_device.

Sorry, but the original code really wants a rewrite to use pci_driver.

It's broken to no end, and pci_get_device won't fix the races.


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] [PATCH 2.6.9-rc2-mm4 fore200e.c] convert

[Matthew Wilcox]

[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]

On Thu, Sep 30, 2004 at 11:29:48AM +0200, Tobias Klauser wrote:
> I'm sending this only to kernel-janitor since I'm not sure, if I do this 
> right (It's my first patch). It compiled without problems here.
> 
> Description: Use pci_get_device instead of pci_find_device.

You can't just replace pci_find_device() with pci_get_device().  Otherwise
it'd all be much simpler.  You must understand what the code is doing, and
figure out what needs to be done to be hotplug safe.  You need to read
Documentation/pci.txt and understand it.

> 10:24:43.000000000 +0200
> +++ linux-2.6.9-rc2-mm4/drivers/atm/fore200e.c  2004-09-30 
> 10:41:20.368794120 +0200
> @@ -644,7 +644,7 @@ fore200e_pca_detect(const struct fore200
>      int              count = index;
> 
>      do {
> -       pci_dev = pci_find_device(PCI_VENDOR_ID_FORE, 
> PCI_DEVICE_ID_FORE_PCA200E, pci_dev);
> +       pci_dev = pci_get_device(PCI_VENDOR_ID_FORE, 
> PCI_DEVICE_ID_FORE_PCA200E, pci_dev);
>         if (pci_dev == NULL)
>             return NULL;
>      } while (count--);

> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/kernel-janitors


-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] [PATCH 2.6.9-rc2-mm4 fore200e.c] convert

[Greg KH]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

On Thu, Sep 30, 2004 at 11:29:48AM +0200, Tobias Klauser wrote:
> I'm sending this only to kernel-janitor since I'm not sure, if I do this 
> right (It's my first patch). It compiled without problems here.
> 
> Description: Use pci_get_device instead of pci_find_device.
> 
> Signed-off-by: Tobias Klauser <tklauser@nuerscht.ch>
> 
> diff -Nrup linux-2.6.9-rc2-mm4-vanilla/drivers/atm/fore200e.c 
> linux-2.6.9-rc2-mm4/drivers/atm/fore200e.c
> --- linux-2.6.9-rc2-mm4-vanilla/drivers/atm/fore200e.c  2004-09-30 
> 10:24:43.000000000 +0200

Becides the other errors mentioned in the patch, it is also linewrapped
and can't be applied :(

thanks,

greg k-h

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors