From: "Andrey S. Klochko" <aklochko@acipower.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Franz Pletz <franz_pletz@t-online.de>,
Michal Rokos <michal@rokos.info>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH 2.6] Natsemi - remove compilation warnings
Date: Thu, 30 Sep 2004 14:09:28 -0400 [thread overview]
Message-ID: <415C4BD8.40005@acipower.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0409300951150.2403@ppc970.osdl.org>
Linus Torvalds wrote:
>
> * One readl should be good to PCI @ 100MHz
> */
> -#define mii_delay(dev) readl(dev->base_addr + EECtrl)
> +#define mii_delay(dev) readl(ioaddr + EECtrl)
^^^
Probably this should be
+#define mii_delay(ioaddr) readl(ioaddr + EECtrl)
and than change all occurrences of
mii_delay(dev) to mii_delay(ioaddr)
?
> static int mii_getbit (struct net_device *dev)
> {
Thanks,
Andrey
-----------
Andrey Klochko
System Administrator
Applied Concepts, Inc.
next prev parent reply other threads:[~2004-09-30 18:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-23 7:58 [PATCH 2.6] Natsemi - remove compilation warnings Michal Rokos
2004-09-23 14:18 ` Michal Rokos
2004-09-30 16:44 ` Franz Pletz
2004-09-30 17:24 ` Linus Torvalds
2004-09-30 18:09 ` Andrey S. Klochko [this message]
2004-09-30 18:22 ` Linus Torvalds
2004-09-30 18:16 ` Franz Pletz
2004-09-30 18:21 ` Jeff Garzik
2004-09-30 18:33 ` Linus Torvalds
2004-09-30 18:40 ` Tim Hockin
2004-09-30 19:53 ` David S. Miller
2004-09-30 20:08 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=415C4BD8.40005@acipower.com \
--to=aklochko@acipower.com \
--cc=akpm@osdl.org \
--cc=franz_pletz@t-online.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal@rokos.info \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.