From: Jeff Garzik <jgarzik@pobox.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: torvalds@osdl.org, franz_pletz@t-online.de, michal@rokos.info,
linux-kernel@vger.kernel.org, akpm@osdl.org,
manfred@colorfullife.com
Subject: Re: [PATCH 2.6] Natsemi - remove compilation warnings
Date: Thu, 30 Sep 2004 16:08:26 -0400 [thread overview]
Message-ID: <415C67BA.5040808@pobox.com> (raw)
In-Reply-To: <20040930125317.5622a909.davem@davemloft.net>
David S. Miller wrote:
> On Thu, 30 Sep 2004 14:21:57 -0400
> Jeff Garzik <jgarzik@pobox.com> wrote:
>
>
>>Wouldn't it be better to just phase out the base of dev->base_addr
>>completely? I tend to prefer adding a "void __iomem *regs" to struct
>>netdev_private, and ignore dev->base_addr completely.
>
>
> Yes, this is the way to go.
>
> (BTW, Jeff, technically it's the 'ifmap' that the user uses
> to pass base_addr into the kernel. The kernel drivers use
> the netdev struct one, which is an unsigned long)
Yep, that's why it's truncated to 16-bits in ifconfig output.
Jeff
prev parent reply other threads:[~2004-09-30 20:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-23 7:58 [PATCH 2.6] Natsemi - remove compilation warnings Michal Rokos
2004-09-23 14:18 ` Michal Rokos
2004-09-30 16:44 ` Franz Pletz
2004-09-30 17:24 ` Linus Torvalds
2004-09-30 18:09 ` Andrey S. Klochko
2004-09-30 18:22 ` Linus Torvalds
2004-09-30 18:16 ` Franz Pletz
2004-09-30 18:21 ` Jeff Garzik
2004-09-30 18:33 ` Linus Torvalds
2004-09-30 18:40 ` Tim Hockin
2004-09-30 19:53 ` David S. Miller
2004-09-30 20:08 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=415C67BA.5040808@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=franz_pletz@t-online.de \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=michal@rokos.info \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.