All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: nfs@lists.sourceforge.net, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lockd
Date: Mon, 04 Oct 2004 15:25:51 -0400	[thread overview]
Message-ID: <4161A3BF.4020908@RedHat.com> (raw)
In-Reply-To: <1096912231.22446.60.camel@lade.trondhjem.org>



Trond Myklebust wrote:

>P=E5 m=E5 , 04/10/2004 klokka 18:24, skreiv Steve Dickson:
>
> =20
>
>>Hey Neil,
>>   =20
>>
>
>Hey! This is the client side NLM code... 8-)
> =20
>
Sorry buddy.... I'm having one of those days!!!! :-\

>Note that you probably also want to move the call to
>set_current_state(TASK_INTERRUPTIBLE) inside the loop. In that case yo=
u
>can also remove the call to set_current_state(TASK_RUNNING) ('cos
>schedule_timeout() will do that for you).
>
> =20
>
Ok...

>Also, why aren't you using the more standard DECLARE_WAITQUEUE(__wait)=
?
> =20
>
I guess I didn't realize that would be a better way to do it... I'll=20
look into to...

thanks,

SteveD.

WARNING: multiple messages have this Message-ID (diff)
From: Steve Dickson <SteveD@redhat.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: nfs@lists.sourceforge.net, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lockd
Date: Mon, 04 Oct 2004 15:25:51 -0400	[thread overview]
Message-ID: <4161A3BF.4020908@RedHat.com> (raw)
In-Reply-To: <1096912231.22446.60.camel@lade.trondhjem.org>



Trond Myklebust wrote:

>På må , 04/10/2004 klokka 18:24, skreiv Steve Dickson:
>
>  
>
>>Hey Neil,
>>    
>>
>
>Hey! This is the client side NLM code... 8-)
>  
>
Sorry buddy.... I'm having one of those days!!!! :-\

>Note that you probably also want to move the call to
>set_current_state(TASK_INTERRUPTIBLE) inside the loop. In that case you
>can also remove the call to set_current_state(TASK_RUNNING) ('cos
>schedule_timeout() will do that for you).
>
>  
>
Ok...

>Also, why aren't you using the more standard DECLARE_WAITQUEUE(__wait)?
>  
>
I guess I didn't realize that would be a better way to do it... I'll 
look into to...

thanks,

SteveD.


  reply	other threads:[~2004-10-04 19:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-04 16:24 [PATCH] lockd Steve Dickson
2004-10-04 17:50 ` Trond Myklebust
2004-10-04 17:50   ` Trond Myklebust
2004-10-04 19:25   ` Steve Dickson [this message]
2004-10-04 19:25     ` Steve Dickson
2004-10-04 18:01 ` Trond Myklebust
2004-10-04 18:01   ` Trond Myklebust
2004-10-04 18:13   ` Arjan van de Ven
2004-10-04 18:22     ` Trond Myklebust
2004-10-04 18:22       ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4161A3BF.4020908@RedHat.com \
    --to=steved@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nfs@lists.sourceforge.net \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.