* [Kernel-janitors] [PATCH 2.6][2/54] arch/i386/pci/acpi.c Use
@ 2004-10-06 20:23 ` Hanna Linder
0 siblings, 0 replies; 4+ messages in thread
From: Hanna Linder @ 2004-10-06 20:23 UTC (permalink / raw)
To: lkml; +Cc: kernel-janitors, greg, hannal, hch
[-- Attachment #1: Type: text/plain, Size: 952 bytes --]
Using the new for_each_pci_dev macro. Compiled and boot tested.
Hanna Linder
IBM Linux Technology Center
Signed-off-by: Hanna Linder <hannal@us.ibm.com>
---
diff -Nrup linux-2.6.9-rc3-mm2cln/arch/i386/pci/acpi.c linux-2.6.9-rc3-mm2patch3/arch/i386/pci/acpi.c
--- linux-2.6.9-rc3-mm2cln/arch/i386/pci/acpi.c 2004-10-04 11:38:04.000000000 -0700
+++ linux-2.6.9-rc3-mm2patch3/arch/i386/pci/acpi.c 2004-10-06 12:27:55.818932576 -0700
@@ -41,7 +41,7 @@ static int __init pci_acpi_init(void)
printk(KERN_INFO "** was specified. If this was required to make a driver work,\n");
printk(KERN_INFO "** please email the output of \"lspci\" to bjorn.helgaas@hp.com\n");
printk(KERN_INFO "** so I can fix the driver.\n");
- while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL)
+ for_each_pci_dev(dev);
acpi_pci_irq_enable(dev);
} else {
printk(KERN_INFO "** PCI interrupts are no longer routed automatically. If this\n");
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2.6][2/54] arch/i386/pci/acpi.c Use for_each_pci_dev macro
@ 2004-10-06 20:23 ` Hanna Linder
0 siblings, 0 replies; 4+ messages in thread
From: Hanna Linder @ 2004-10-06 20:23 UTC (permalink / raw)
To: lkml; +Cc: kernel-janitors, greg, hannal, hch
Using the new for_each_pci_dev macro. Compiled and boot tested.
Hanna Linder
IBM Linux Technology Center
Signed-off-by: Hanna Linder <hannal@us.ibm.com>
---
diff -Nrup linux-2.6.9-rc3-mm2cln/arch/i386/pci/acpi.c linux-2.6.9-rc3-mm2patch3/arch/i386/pci/acpi.c
--- linux-2.6.9-rc3-mm2cln/arch/i386/pci/acpi.c 2004-10-04 11:38:04.000000000 -0700
+++ linux-2.6.9-rc3-mm2patch3/arch/i386/pci/acpi.c 2004-10-06 12:27:55.818932576 -0700
@@ -41,7 +41,7 @@ static int __init pci_acpi_init(void)
printk(KERN_INFO "** was specified. If this was required to make a driver work,\n");
printk(KERN_INFO "** please email the output of \"lspci\" to bjorn.helgaas@hp.com\n");
printk(KERN_INFO "** so I can fix the driver.\n");
- while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL)
+ for_each_pci_dev(dev);
acpi_pci_irq_enable(dev);
} else {
printk(KERN_INFO "** PCI interrupts are no longer routed automatically. If this\n");
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2.6][2/54] arch/i386/pci/acpi.c Use for_each_pci_dev macro
2004-10-06 20:23 ` [PATCH 2.6][2/54] arch/i386/pci/acpi.c Use for_each_pci_dev macro Hanna Linder
(?)
@ 2004-10-07 9:30 ` David Vrabel
2004-10-07 19:28 ` Hanna Linder
-1 siblings, 1 reply; 4+ messages in thread
From: David Vrabel @ 2004-10-07 9:30 UTC (permalink / raw)
To: Hanna Linder; +Cc: Linux Kernel
Hanna Linder wrote:
>
> + for_each_pci_dev(dev);
That semicolon doesn't look right.
> acpi_pci_irq_enable(dev);
David Vrabel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2.6][2/54] arch/i386/pci/acpi.c Use for_each_pci_dev macro
2004-10-07 9:30 ` David Vrabel
@ 2004-10-07 19:28 ` Hanna Linder
0 siblings, 0 replies; 4+ messages in thread
From: Hanna Linder @ 2004-10-07 19:28 UTC (permalink / raw)
To: David Vrabel; +Cc: Hanna Linder, Linux Kernel, greg
--On Thursday, October 07, 2004 10:30:33 AM +0100 David Vrabel <dvrabel@arcom.com> wrote:
> Hanna Linder wrote:
>>
>> + for_each_pci_dev(dev);
>
> That semicolon doesn't look right.
Woops. You are right. Here is the reroll
Signed-off-by: Hanna Linder <hannal@us.ibm.com>
---
diff -Nrup linux-2.6.9-rc3-mm2cln/arch/i386/pci/acpi.c linux-2.6.9-rc3-mm2patch/arch/i386/pci/acpi.c
--- linux-2.6.9-rc3-mm2cln/arch/i386/pci/acpi.c 2004-10-04 11:38:04.000000000 -0700
+++ linux-2.6.9-rc3-mm2patch/arch/i386/pci/acpi.c 2004-10-07 12:21:49.825530848 -0700
@@ -41,7 +41,7 @@ static int __init pci_acpi_init(void)
printk(KERN_INFO "** was specified. If this was required to make a driver work,\n");
printk(KERN_INFO "** please email the output of \"lspci\" to bjorn.helgaas@hp.com\n");
printk(KERN_INFO "** so I can fix the driver.\n");
- while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL)
+ for_each_pci_dev(dev)
acpi_pci_irq_enable(dev);
} else {
printk(KERN_INFO "** PCI interrupts are no longer routed automatically. If this\n");
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-10-07 19:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-06 20:23 [Kernel-janitors] [PATCH 2.6][2/54] arch/i386/pci/acpi.c Use Hanna Linder
2004-10-06 20:23 ` [PATCH 2.6][2/54] arch/i386/pci/acpi.c Use for_each_pci_dev macro Hanna Linder
2004-10-07 9:30 ` David Vrabel
2004-10-07 19:28 ` Hanna Linder
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.