From: Jeff Garzik <jgarzik@pobox.com>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: netdev <netdev@oss.sgi.com>, mlindner@syskonnect.de
Subject: Re: [PATCH] skfp: remove assignment expression in conditional (sparse)
Date: Fri, 15 Oct 2004 15:24:53 -0400 [thread overview]
Message-ID: <41702405.6070100@pobox.com> (raw)
In-Reply-To: <4169BB68.7030206@osdl.org>
Randy.Dunlap wrote:
> Fix sparse warning:
> drivers/net/skfp/hwmtm.c:1904:20: warning: assignment expression in
> conditional
>
>
> ------------------------------------------------------------------------
>
>
> Fix sparse warning:
> drivers/net/skfp/hwmtm.c:1904:20: warning: assignment expression in conditional
>
> Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
>
> diffstat:=
> drivers/net/skfp/hwmtm.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -Naurp ./drivers/net/skfp/hwmtm.c~skfp_expr ./drivers/net/skfp/hwmtm.c
> --- ./drivers/net/skfp/hwmtm.c~skfp_expr 2004-08-13 22:36:59.000000000 -0700
> +++ ./drivers/net/skfp/hwmtm.c 2004-10-10 15:15:21.090772760 -0700
> @@ -1901,7 +1901,7 @@ void smt_send_mbuf(struct s_smc *smc, SM
> }
>
> if (!smc->hw.mac_ring_is_up || frag_count > queue->tx_free) {
> - if (frame_status &= ~LAN_TX) {
> + if ((frame_status &= ~LAN_TX) != 0) {
I would prefer to fix a 'assignment expression in conditional' warning
by splitting the assignment and the test.
Jeff
next prev parent reply other threads:[~2004-10-15 19:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-10 22:44 [PATCH] skfp: remove assignment expression in conditional (sparse) Randy.Dunlap
2004-10-15 19:24 ` Jeff Garzik [this message]
2004-10-15 21:50 ` [PATCH] skfp: remove assignment expression in conditional (sparse)(v2) Randy.Dunlap
2004-10-15 23:54 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41702405.6070100@pobox.com \
--to=jgarzik@pobox.com \
--cc=mlindner@syskonnect.de \
--cc=netdev@oss.sgi.com \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.