[PATCH] skfp: remove assignment expression in conditional (sparse)(v2)

["Randy.Dunlap" <rddunlap@osdl.org>]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

> I would prefer to fix a 'assignment expression in conditional' warning 
> by splitting the assignment and the test.
> 
>     Jeff

OK, here you are.

-- 
~Randy

[-- Attachment #2: skfp_expr_v2.patch --]
[-- Type: text/x-patch, Size: 755 bytes --]


Fix sparse warning:
drivers/net/skfp/hwmtm.c:1904:20: warning: assignment expression in conditional

Signed-off-by: Randy Dunlap <rddunlap@osdl.org>


diffstat:=
 drivers/net/skfp/hwmtm.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -Naurp ./drivers/net/skfp/hwmtm.c~skfp_expr ./drivers/net/skfp/hwmtm.c
--- ./drivers/net/skfp/hwmtm.c~skfp_expr	2004-08-13 22:36:59.000000000 -0700
+++ ./drivers/net/skfp/hwmtm.c	2004-10-15 14:47:41.942720928 -0700
@@ -1901,7 +1901,8 @@ void smt_send_mbuf(struct s_smc *smc, SM
 	}
 
 	if (!smc->hw.mac_ring_is_up || frag_count > queue->tx_free) {
-		if (frame_status &= ~LAN_TX) {
+		frame_status &= ~LAN_TX;
+		if (frame_status) {
 			DB_TX("Ring is down: terminate LAN_TX",0,0,2) ;
 		}
 		else {