All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Michael Riesch <michael.riesch@wolfvision.net>,
	Peter Geis <pgwipeout@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
	arm-mail-list <linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Fix SoQuartz CM4IO usb
Date: Sat, 11 Jun 2022 15:50:08 +0200	[thread overview]
Message-ID: <4178848.3VsfAaAtOV@phil> (raw)
In-Reply-To: <CAMdYzYqJ2S8K2NCH1uQ2xDjTfLmePPv5TzgeXZa0EG6XdGQzBQ@mail.gmail.com>

Am Freitag, 10. Juni 2022, 16:44:23 CEST schrieb Peter Geis:
> On Fri, Jun 10, 2022 at 9:26 AM Peter Geis <pgwipeout@gmail.com> wrote:
> >
> > The SoQuartz CM4-IO should support otg mode, however it currently
> > defaults to device mode when otg is enabled. Force it to host mode to
> > retain the previous behavior.
> 
> It would seem the role-switch issue is more widespread than originally
> thought, affecting other boards where automatic control should work.
> Please hold this patch while I investigate further.

ok!

I guess this also applies to
	"arm64: dts: rockchip: Fix Quartz64-A dwc3 otg port behavior"?


Heiko


> >
> > Fixes: bc405bb3eeee ("arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk356x")
> >
> > Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts b/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts
> > index e00568a6be5c..56764fae9f9d 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts
> > @@ -169,6 +169,7 @@ &usb2phy0_otg {
> >  };
> >
> >  &usb_host0_xhci {
> > +       dr_mode = "host";
> >         status = "okay";
> >  };
> >
> > --
> > 2.25.1
> >
> 





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Michael Riesch <michael.riesch@wolfvision.net>,
	Peter Geis <pgwipeout@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
	arm-mail-list <linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Fix SoQuartz CM4IO usb
Date: Sat, 11 Jun 2022 15:50:08 +0200	[thread overview]
Message-ID: <4178848.3VsfAaAtOV@phil> (raw)
In-Reply-To: <CAMdYzYqJ2S8K2NCH1uQ2xDjTfLmePPv5TzgeXZa0EG6XdGQzBQ@mail.gmail.com>

Am Freitag, 10. Juni 2022, 16:44:23 CEST schrieb Peter Geis:
> On Fri, Jun 10, 2022 at 9:26 AM Peter Geis <pgwipeout@gmail.com> wrote:
> >
> > The SoQuartz CM4-IO should support otg mode, however it currently
> > defaults to device mode when otg is enabled. Force it to host mode to
> > retain the previous behavior.
> 
> It would seem the role-switch issue is more widespread than originally
> thought, affecting other boards where automatic control should work.
> Please hold this patch while I investigate further.

ok!

I guess this also applies to
	"arm64: dts: rockchip: Fix Quartz64-A dwc3 otg port behavior"?


Heiko


> >
> > Fixes: bc405bb3eeee ("arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk356x")
> >
> > Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts b/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts
> > index e00568a6be5c..56764fae9f9d 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts
> > @@ -169,6 +169,7 @@ &usb2phy0_otg {
> >  };
> >
> >  &usb_host0_xhci {
> > +       dr_mode = "host";
> >         status = "okay";
> >  };
> >
> > --
> > 2.25.1
> >
> 





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Michael Riesch <michael.riesch@wolfvision.net>,
	Peter Geis <pgwipeout@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
	arm-mail-list <linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Fix SoQuartz CM4IO usb
Date: Sat, 11 Jun 2022 15:50:08 +0200	[thread overview]
Message-ID: <4178848.3VsfAaAtOV@phil> (raw)
In-Reply-To: <CAMdYzYqJ2S8K2NCH1uQ2xDjTfLmePPv5TzgeXZa0EG6XdGQzBQ@mail.gmail.com>

Am Freitag, 10. Juni 2022, 16:44:23 CEST schrieb Peter Geis:
> On Fri, Jun 10, 2022 at 9:26 AM Peter Geis <pgwipeout@gmail.com> wrote:
> >
> > The SoQuartz CM4-IO should support otg mode, however it currently
> > defaults to device mode when otg is enabled. Force it to host mode to
> > retain the previous behavior.
> 
> It would seem the role-switch issue is more widespread than originally
> thought, affecting other boards where automatic control should work.
> Please hold this patch while I investigate further.

ok!

I guess this also applies to
	"arm64: dts: rockchip: Fix Quartz64-A dwc3 otg port behavior"?


Heiko


> >
> > Fixes: bc405bb3eeee ("arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk356x")
> >
> > Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts b/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts
> > index e00568a6be5c..56764fae9f9d 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts
> > @@ -169,6 +169,7 @@ &usb2phy0_otg {
> >  };
> >
> >  &usb_host0_xhci {
> > +       dr_mode = "host";
> >         status = "okay";
> >  };
> >
> > --
> > 2.25.1
> >
> 





  reply	other threads:[~2022-06-11 13:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10 13:26 [PATCH] arm64: dts: rockchip: Fix SoQuartz CM4IO usb Peter Geis
2022-06-10 13:26 ` Peter Geis
2022-06-10 13:26 ` Peter Geis
2022-06-10 14:44 ` Peter Geis
2022-06-10 14:44   ` Peter Geis
2022-06-10 14:44   ` Peter Geis
2022-06-11 13:50   ` Heiko Stuebner [this message]
2022-06-11 13:50     ` Heiko Stuebner
2022-06-11 13:50     ` Heiko Stuebner
2022-06-11 13:53     ` Peter Geis
2022-06-11 13:53       ` Peter Geis
2022-06-11 13:53       ` Peter Geis
2022-06-11 14:59       ` Heiko Stuebner
2022-06-11 14:59         ` Heiko Stuebner
2022-06-11 14:59         ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4178848.3VsfAaAtOV@phil \
    --to=heiko@sntech.de \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=michael.riesch@wolfvision.net \
    --cc=pgwipeout@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.