From: Jeff Garzik <jgarzik@pobox.com>
To: maximilian attems <janitor@sternwelten.at>
Cc: Margit Schubert-While <margitsw@t-online.de>,
Nishanth Aravamudan <nacc@us.ibm.com>,
hvr@gnu.org, mcgrof@studorgs.rutgers.edu,
kernel-janitors@lists.osdl.org, prism54-devel@prism54.org,
netdev@oss.sgi.com, Domen Puncer <domen@coderock.org>,
linux-kernel@vger.kernel.org
Subject: [KJ] Re: [patch 2.4] back port msleep(), msleep_interruptible()
Date: Sat, 30 Oct 2004 22:41:10 +0000 [thread overview]
Message-ID: <41841886.2080609@pobox.com> (raw)
In-Reply-To: <20041030222228.GB1456@stro.at>
[-- Attachment #1: Type: text/plain, Size: 945 bytes --]
maximilian attems wrote:
> diff -puN include/linux/delay.h~add-msleep-2.4 include/linux/delay.h
> --- a/include/linux/delay.h~add-msleep-2.4 2004-10-30 22:48:46.000000000 +0200
> +++ b/include/linux/delay.h 2004-10-30 22:48:46.000000000 +0200
> @@ -34,4 +34,12 @@ extern unsigned long loops_per_jiffy;
> ({unsigned long msec=(n); while (msec--) udelay(1000);}))
> #endif
>
> +void msleep(unsigned int msecs);
> +unsigned long msleep_interruptible(unsigned int msecs);
> +
> +static inline void ssleep(unsigned int seconds)
[...]
> +static inline unsigned int jiffies_to_msecs(const unsigned long j)
> +static inline unsigned int jiffies_to_usecs(const unsigned long j)
> +static inline unsigned long msecs_to_jiffies(const unsigned int m)
I'm pretty sure more than one of these symbols clashes with a symbol
defined locally in a driver. I like the patch but we can't apply it
until the impact on existing code is evaluated.
Jeff
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jgarzik@pobox.com>
To: maximilian attems <janitor@sternwelten.at>
Cc: Margit Schubert-While <margitsw@t-online.de>,
Nishanth Aravamudan <nacc@us.ibm.com>,
hvr@gnu.org, mcgrof@studorgs.rutgers.edu,
kernel-janitors@lists.osdl.org, prism54-devel@prism54.org,
netdev@oss.sgi.com, Domen Puncer <domen@coderock.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 2.4] back port msleep(), msleep_interruptible()
Date: Sat, 30 Oct 2004 18:41:10 -0400 [thread overview]
Message-ID: <41841886.2080609@pobox.com> (raw)
In-Reply-To: <20041030222228.GB1456@stro.at>
maximilian attems wrote:
> diff -puN include/linux/delay.h~add-msleep-2.4 include/linux/delay.h
> --- a/include/linux/delay.h~add-msleep-2.4 2004-10-30 22:48:46.000000000 +0200
> +++ b/include/linux/delay.h 2004-10-30 22:48:46.000000000 +0200
> @@ -34,4 +34,12 @@ extern unsigned long loops_per_jiffy;
> ({unsigned long msec=(n); while (msec--) udelay(1000);}))
> #endif
>
> +void msleep(unsigned int msecs);
> +unsigned long msleep_interruptible(unsigned int msecs);
> +
> +static inline void ssleep(unsigned int seconds)
[...]
> +static inline unsigned int jiffies_to_msecs(const unsigned long j)
> +static inline unsigned int jiffies_to_usecs(const unsigned long j)
> +static inline unsigned long msecs_to_jiffies(const unsigned int m)
I'm pretty sure more than one of these symbols clashes with a symbol
defined locally in a driver. I like the patch but we can't apply it
until the impact on existing code is evaluated.
Jeff
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jgarzik@pobox.com>
To: maximilian attems <janitor@sternwelten.at>
Cc: netdev@oss.sgi.com, mcgrof@studorgs.rutgers.edu,
linux-kernel@vger.kernel.org, hvr@gnu.org,
Margit Schubert-While <margitsw@t-online.de>,
kernel-janitors@lists.osdl.org,
Nishanth Aravamudan <nacc@us.ibm.com>,
prism54-devel@prism54.org, Domen Puncer <domen@coderock.org>
Subject: Re: [patch 2.4] back port msleep(), msleep_interruptible()
Date: Sat, 30 Oct 2004 18:41:10 -0400 [thread overview]
Message-ID: <41841886.2080609@pobox.com> (raw)
In-Reply-To: <20041030222228.GB1456@stro.at>
maximilian attems wrote:
> diff -puN include/linux/delay.h~add-msleep-2.4 include/linux/delay.h
> --- a/include/linux/delay.h~add-msleep-2.4 2004-10-30 22:48:46.000000000 +0200
> +++ b/include/linux/delay.h 2004-10-30 22:48:46.000000000 +0200
> @@ -34,4 +34,12 @@ extern unsigned long loops_per_jiffy;
> ({unsigned long msec=(n); while (msec--) udelay(1000);}))
> #endif
>
> +void msleep(unsigned int msecs);
> +unsigned long msleep_interruptible(unsigned int msecs);
> +
> +static inline void ssleep(unsigned int seconds)
[...]
> +static inline unsigned int jiffies_to_msecs(const unsigned long j)
> +static inline unsigned int jiffies_to_usecs(const unsigned long j)
> +static inline unsigned long msecs_to_jiffies(const unsigned int m)
I'm pretty sure more than one of these symbols clashes with a symbol
defined locally in a driver. I like the patch but we can't apply it
until the impact on existing code is evaluated.
Jeff
next prev parent reply other threads:[~2004-10-30 22:41 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-23 22:13 [Kernel-janitors] [PATCH 2.6.9-rc2 17/38] net/islpci_dev: replace Nishanth Aravamudan
2004-09-23 22:55 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 17/38] net/islpci_dev: Luis R. Rodriguez
2004-09-23 22:55 ` [PATCH 2.6.9-rc2 17/38] net/islpci_dev: replace schedule_timeout() with msleep() Luis R. Rodriguez
2004-09-24 7:43 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 17/38] net/islpci_dev: Margit Schubert-While
2004-09-24 7:43 ` [PATCH 2.6.9-rc2 17/38] net/islpci_dev: replace schedule_timeout() with msleep() Margit Schubert-While
2004-09-24 16:34 ` [Kernel-janitors] [PATCH 2.6.9-rc2 17/38] net/islpci_dev: replace maximilian attems
2004-09-24 16:34 ` [Kernel-janitors] [PATCH 2.6.9-rc2 17/38] net/islpci_dev: replace schedule_timeout() with msleep() maximilian attems
2004-10-01 4:15 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 17/38] net/islpci_dev: Jeff Garzik
2004-10-01 4:15 ` [PATCH 2.6.9-rc2 17/38] net/islpci_dev: replace schedule_timeout() with msleep() Jeff Garzik
2004-10-01 7:04 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 17/38] net/islpci_dev: Margit Schubert-While
2004-10-01 7:04 ` [PATCH 2.6.9-rc2 17/38] net/islpci_dev: replace schedule_timeout() with msleep() Margit Schubert-While
2004-10-01 16:55 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 17/38] net/islpci_dev: Greg KH
2004-10-01 16:55 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 17/38] net/islpci_dev: replace schedule_timeout() with msleep() Greg KH
2004-10-02 9:07 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 17/38] Margit Schubert-While
2004-10-02 9:07 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 17/38] net/islpci_dev: replace schedule_timeout() with msleep() Margit Schubert-While
2004-10-04 21:04 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 17/38] net/islpci_dev: Jeff Garzik
2004-10-04 21:04 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 17/38] net/islpci_dev: replace schedule_timeout() with msleep() Jeff Garzik
2004-10-30 22:22 ` [KJ] [patch 2.4] back port msleep(), msleep_interruptible() maximilian attems
2004-10-30 22:22 ` maximilian attems
2004-10-30 22:22 ` maximilian attems
2004-10-30 22:41 ` Jeff Garzik [this message]
2004-10-30 22:41 ` Jeff Garzik
2004-10-30 22:41 ` Jeff Garzik
2004-10-30 22:59 ` [KJ] " Nish Aravamudan
2004-10-30 22:59 ` Nish Aravamudan
2004-10-30 22:59 ` Nish Aravamudan
2004-10-30 22:59 ` Nish Aravamudan
2004-10-30 23:19 ` maximilian attems
2004-10-30 23:19 ` maximilian attems
2004-10-30 23:19 ` maximilian attems
2004-10-30 23:19 ` maximilian attems
2004-10-31 14:43 ` maximilian attems
2004-10-31 14:43 ` maximilian attems
2004-10-31 14:43 ` [KJ] " maximilian attems
2004-10-31 14:43 ` maximilian attems
2004-10-31 14:44 ` [KJ] [patch 1/6] " maximilian attems
2004-10-31 14:44 ` maximilian attems
2004-10-31 14:44 ` maximilian attems
2004-10-31 14:44 ` [KJ] [patch 2/6] libata remove duplicate definition maximilian attems
2004-10-31 14:44 ` [patch 2/6] libata remove duplicate definition msecs_to_jiffies() maximilian attems
2004-10-31 14:44 ` [KJ] [patch 3/6] sx8 remove duplicate definition msleep(), maximilian attems
2004-10-31 14:44 ` [patch 3/6] sx8 remove duplicate definition msleep(), msecs_to_jiffies() maximilian attems
2004-10-31 14:45 ` [KJ] [patch 4/6] char/shwdt remove duplicate msecs_to_jiffies() maximilian attems
2004-10-31 14:45 ` maximilian attems
2004-10-31 14:45 ` [KJ] [patch 5/6] sata_promise remove duplicate msleep() definition maximilian attems
2004-10-31 14:45 ` maximilian attems
2004-10-31 14:45 ` [KJ] [patch 6/6] libata remove msleep_libata() maximilian attems
2004-10-31 14:45 ` maximilian attems
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41841886.2080609@pobox.com \
--to=jgarzik@pobox.com \
--cc=domen@coderock.org \
--cc=hvr@gnu.org \
--cc=janitor@sternwelten.at \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=margitsw@t-online.de \
--cc=mcgrof@studorgs.rutgers.edu \
--cc=nacc@us.ibm.com \
--cc=netdev@oss.sgi.com \
--cc=prism54-devel@prism54.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.