All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/1] gfs2: incorrect check for debugfs	returns
Date: Mon, 30 Mar 2015 10:16:00 -0400 (EDT)	[thread overview]
Message-ID: <418606603.5467773.1427724960573.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1427164618-568-1-git-send-email-csong84@gatech.edu>

----- Original Message -----
> debugfs_create_dir and debugfs_create_file may return -ENODEV when debugfs
> is not configured, so the return value should be checked against ERROR_VALUE
> as well, otherwise the later dereference of the dentry pointer would crash
> the kernel.
> 
> Signed-off-by: Chengyu Song <csong84@gatech.edu>
> ---
>  fs/gfs2/glock.c | 47 ++++++++++++++++++++++++++++-------------------
>  1 file changed, 28 insertions(+), 19 deletions(-)

Hi,

I've now added this patch to the for-next branch of the linux-gfs2.git
tree. Thanks.

Regards,

Bob Peterson
Red Hat File Systems



WARNING: multiple messages have this Message-ID (diff)
From: Bob Peterson <rpeterso@redhat.com>
To: Chengyu Song <csong84@gatech.edu>
Cc: swhiteho@redhat.com, cluster-devel@redhat.com,
	linux-kernel@vger.kernel.org, blee@gatech.edu, taesoo@gatech.edu,
	changwoo@gatech.edu, sanidhya@gatech.edu
Subject: Re: [Cluster-devel] [PATCH 1/1] gfs2: incorrect check for debugfs returns
Date: Mon, 30 Mar 2015 10:16:00 -0400 (EDT)	[thread overview]
Message-ID: <418606603.5467773.1427724960573.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1427164618-568-1-git-send-email-csong84@gatech.edu>

----- Original Message -----
> debugfs_create_dir and debugfs_create_file may return -ENODEV when debugfs
> is not configured, so the return value should be checked against ERROR_VALUE
> as well, otherwise the later dereference of the dentry pointer would crash
> the kernel.
> 
> Signed-off-by: Chengyu Song <csong84@gatech.edu>
> ---
>  fs/gfs2/glock.c | 47 ++++++++++++++++++++++++++++-------------------
>  1 file changed, 28 insertions(+), 19 deletions(-)

Hi,

I've now added this patch to the for-next branch of the linux-gfs2.git
tree. Thanks.

Regards,

Bob Peterson
Red Hat File Systems

  parent reply	other threads:[~2015-03-30 14:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24  2:36 [Cluster-devel] [PATCH 1/1] gfs2: incorrect check for debugfs returns Chengyu Song
2015-03-24  2:36 ` Chengyu Song
2015-03-24 10:21 ` [Cluster-devel] " Steven Whitehouse
2015-03-24 10:21   ` Steven Whitehouse
2015-03-30 14:16 ` Bob Peterson [this message]
2015-03-30 14:16   ` [Cluster-devel] " Bob Peterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=418606603.5467773.1427724960573.JavaMail.zimbra@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.