* cache_hot_time @ 2004-11-04 21:04 Anton Blanchard 2004-11-05 1:31 ` cache_hot_time Nick Piggin 0 siblings, 1 reply; 4+ messages in thread From: Anton Blanchard @ 2004-11-04 21:04 UTC (permalink / raw) To: linux-kernel; +Cc: nickpiggin, pj, colpatch Hi, Im catching up on all the scheduler changes, and I noticed some large changes in cache_hot_time. All but ia64 seem to have shifted by 1000. Is this intententional? Anton include/linux/topology.h: .cache_hot_time = (5*1000/2), include/asm-i386/topology.h: .cache_hot_time = (10*1000), include/asm-ppc64/topology.h: .cache_hot_time = (10*1000), include/asm-x86_64/topology.h: .cache_hot_time = (10*1000), include/asm-ia64/topology.h: .cache_hot_time = (10*1000000), include/asm-ia64/topology.h: .cache_hot_time = (10*1000000), ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: cache_hot_time 2004-11-04 21:04 cache_hot_time Anton Blanchard @ 2004-11-05 1:31 ` Nick Piggin 2004-11-05 5:04 ` [PATCH] reset cache_hot_time Anton Blanchard 0 siblings, 1 reply; 4+ messages in thread From: Nick Piggin @ 2004-11-05 1:31 UTC (permalink / raw) To: Anton Blanchard; +Cc: linux-kernel, pj, colpatch Anton Blanchard wrote: > Hi, > > Im catching up on all the scheduler changes, and I noticed some large > changes in cache_hot_time. All but ia64 seem to have shifted by 1000. Is > this intententional? > Don't think so. They should be all in units of sched_clock() (ie. ns), so 10ms and 2.5ms are surely the intended values here. > Anton > > include/linux/topology.h: .cache_hot_time = (5*1000/2), > include/asm-i386/topology.h: .cache_hot_time = (10*1000), > include/asm-ppc64/topology.h: .cache_hot_time = (10*1000), > include/asm-x86_64/topology.h: .cache_hot_time = (10*1000), > include/asm-ia64/topology.h: .cache_hot_time = (10*1000000), > include/asm-ia64/topology.h: .cache_hot_time = (10*1000000), > ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] reset cache_hot_time 2004-11-05 1:31 ` cache_hot_time Nick Piggin @ 2004-11-05 5:04 ` Anton Blanchard 2004-11-05 8:32 ` Nick Piggin 0 siblings, 1 reply; 4+ messages in thread From: Anton Blanchard @ 2004-11-05 5:04 UTC (permalink / raw) To: Nick Piggin; +Cc: linux-kernel, pj, colpatch, akpm > Don't think so. They should be all in units of sched_clock() > (ie. ns), so 10ms and 2.5ms are surely the intended values here. OK how does this look? Anton -- Reset cache_hot_time to sane values (in the ms range). Some recent changes resulted in values in the us range. Signed-off-by: Anton Blanchard <anton@samba.org> ===== include/asm-i386/topology.h 1.12 vs edited ===== --- 1.12/include/asm-i386/topology.h 2004-10-19 15:26:52 +10:00 +++ edited/include/asm-i386/topology.h 2004-11-05 15:50:13 +11:00 @@ -78,7 +78,7 @@ .max_interval = 32, \ .busy_factor = 32, \ .imbalance_pct = 125, \ - .cache_hot_time = (10*1000), \ + .cache_hot_time = (10*1000000), \ .cache_nice_tries = 1, \ .per_cpu_gain = 100, \ .flags = SD_LOAD_BALANCE \ ===== include/asm-ppc64/topology.h 1.13 vs edited ===== --- 1.13/include/asm-ppc64/topology.h 2004-10-19 15:26:52 +10:00 +++ edited/include/asm-ppc64/topology.h 2004-11-05 15:49:52 +11:00 @@ -46,7 +46,7 @@ .max_interval = 32, \ .busy_factor = 32, \ .imbalance_pct = 125, \ - .cache_hot_time = (10*1000), \ + .cache_hot_time = (10*1000000), \ .cache_nice_tries = 1, \ .per_cpu_gain = 100, \ .flags = SD_LOAD_BALANCE \ ===== include/asm-x86_64/topology.h 1.13 vs edited ===== --- 1.13/include/asm-x86_64/topology.h 2004-10-19 15:26:52 +10:00 +++ edited/include/asm-x86_64/topology.h 2004-11-05 15:49:37 +11:00 @@ -42,7 +42,7 @@ .max_interval = 32, \ .busy_factor = 32, \ .imbalance_pct = 125, \ - .cache_hot_time = (10*1000), \ + .cache_hot_time = (10*1000000), \ .cache_nice_tries = 1, \ .per_cpu_gain = 100, \ .flags = SD_LOAD_BALANCE \ ===== include/linux/topology.h 1.6 vs edited ===== --- 1.6/include/linux/topology.h 2004-10-19 15:26:51 +10:00 +++ edited/include/linux/topology.h 2004-11-05 15:48:15 +11:00 @@ -113,7 +113,7 @@ .max_interval = 4, \ .busy_factor = 64, \ .imbalance_pct = 125, \ - .cache_hot_time = (5*1000/2), \ + .cache_hot_time = (5*1000000/2), \ .cache_nice_tries = 1, \ .per_cpu_gain = 100, \ .flags = SD_LOAD_BALANCE \ ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] reset cache_hot_time 2004-11-05 5:04 ` [PATCH] reset cache_hot_time Anton Blanchard @ 2004-11-05 8:32 ` Nick Piggin 0 siblings, 0 replies; 4+ messages in thread From: Nick Piggin @ 2004-11-05 8:32 UTC (permalink / raw) To: Anton Blanchard; +Cc: linux-kernel, pj, colpatch, akpm Anton Blanchard wrote: > > >>Don't think so. They should be all in units of sched_clock() >>(ie. ns), so 10ms and 2.5ms are surely the intended values here. > > > OK how does this look? > Seems like the right thing to do. Andrew's picked it up in rc1-mm3. Thanks. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-11-05 8:32 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2004-11-04 21:04 cache_hot_time Anton Blanchard 2004-11-05 1:31 ` cache_hot_time Nick Piggin 2004-11-05 5:04 ` [PATCH] reset cache_hot_time Anton Blanchard 2004-11-05 8:32 ` Nick Piggin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.