From: Patrick McHardy <kaber@trash.net>
To: "Catalin(ux aka Dino) BOIE" <util@deuroconsult.ro>
Cc: linux-net@vger.kernel.org, lartc@mailman.ds9a.nl, netdev@oss.sgi.com
Subject: [LARTC] Re: [PATCH] Use nfmark as a key for u32 classifier
Date: Tue, 09 Nov 2004 05:41:40 +0000 [thread overview]
Message-ID: <41905894.7030809@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.61.0411051317330.23651@webhosting.rdsbv.ro>
Catalin(ux aka Dino) BOIE wrote:
> Hello!
>
> I am glad to announce a patch for u32 to allow matches on nfmark.
> The patch is non intrusive (few lines).
>
>------------------------------------------------------------------------
>
> if ((*(u32*)(ptr+key->off+(off2&key->offmask))^key->val)&key->mask) {
>--- linux.orig/include/linux/pkt_cls.h 2004-10-19 00:53:07.000000000 +0300
>+++ linux/include/linux/pkt_cls.h 2004-11-05 11:00:27.000000000 +0200
>@@ -208,6 +208,7 @@ struct tc_u32_sel
> unsigned char flags;
> unsigned char offshift;
> unsigned char nkeys;
>+ u32 mark;
>
>
^^ Please put this at the end to avoid breaking compatibility
with old tc binaries. BTW, nfmark if unsigned long, which is
64 bit on 64-bit architectures. Probably not worth fixing though,
everyone else got it wrong too.
>
> __u16 offmask;
> __u16 off;
>
>
Regards
Patrick
_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/
WARNING: multiple messages have this Message-ID (diff)
From: Patrick McHardy <kaber@trash.net>
To: "Catalin(ux aka Dino) BOIE" <util@deuroconsult.ro>
Cc: linux-net@vger.kernel.org, lartc@mailman.ds9a.nl, netdev@oss.sgi.com
Subject: Re: [PATCH] Use nfmark as a key for u32 classifier
Date: Tue, 09 Nov 2004 06:41:40 +0100 [thread overview]
Message-ID: <41905894.7030809@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.61.0411051317330.23651@webhosting.rdsbv.ro>
Catalin(ux aka Dino) BOIE wrote:
> Hello!
>
> I am glad to announce a patch for u32 to allow matches on nfmark.
> The patch is non intrusive (few lines).
>
>------------------------------------------------------------------------
>
> if ((*(u32*)(ptr+key->off+(off2&key->offmask))^key->val)&key->mask) {
>--- linux.orig/include/linux/pkt_cls.h 2004-10-19 00:53:07.000000000 +0300
>+++ linux/include/linux/pkt_cls.h 2004-11-05 11:00:27.000000000 +0200
>@@ -208,6 +208,7 @@ struct tc_u32_sel
> unsigned char flags;
> unsigned char offshift;
> unsigned char nkeys;
>+ u32 mark;
>
>
^^ Please put this at the end to avoid breaking compatibility
with old tc binaries. BTW, nfmark if unsigned long, which is
64 bit on 64-bit architectures. Probably not worth fixing though,
everyone else got it wrong too.
>
> __u16 offmask;
> __u16 off;
>
>
Regards
Patrick
next prev parent reply other threads:[~2004-11-09 5:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-05 11:38 [LARTC] [PATCH] Use nfmark as a key for u32 classifier Catalin(ux aka Dino) BOIE
2004-11-05 11:38 ` Catalin(ux aka Dino) BOIE
2004-11-05 15:50 ` jamal
2004-11-08 10:06 ` [LARTC] " Catalin(ux aka Dino) BOIE
2004-11-08 10:06 ` Catalin(ux aka Dino) BOIE
2004-11-09 5:41 ` Patrick McHardy [this message]
2004-11-09 5:41 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41905894.7030809@trash.net \
--to=kaber@trash.net \
--cc=lartc@mailman.ds9a.nl \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=util@deuroconsult.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.