All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prarit Bhargava <prarit@sgi.com>
To: linux-ia64@vger.kernel.org, selinux@tycho.nsa.gov
Subject: SELinux & ia64
Date: Tue, 23 Nov 2004 15:13:27 +0000	[thread overview]
Message-ID: <41A35397.1080001@sgi.com> (raw)

SELinux appears to cause warnings while attempting mounts both at 
boot-time and run-time:

kernel unaligned access to 0xa0000002003a0056, ip=0xa0000001002076d0
kernel unaligned access to 0xa0000002003a005e, ip=0xa0000001002076d0
kernel unaligned access to 0xa0000002003a0066, ip=0xa0000001002076d0
kernel unaligned access to 0xa0000002003a006e, ip=0xa0000001002076d0

I've tracked this to the usage of le32_to_cpu in 

security/selinux/ss/policydb.c

The code in question uses:

    len = le32_to_cpu(buf[0]);

and should be

    len = le32_to_cpu(get_unaligned(&buf[0]));

However, this is probably not a good solution as the get_unaligned macro 
can be expensive
on platforms other than ia64. 

I'm tempted to redefine the le32_to_cpu function for policydb.c for the 
ia64 platform, but
before I go down that road I was wondering if anyone had hit this issue 
elsewhere in the kernel?

Prarit.

WARNING: multiple messages have this Message-ID (diff)
From: Prarit Bhargava <prarit@sgi.com>
To: linux-ia64@vger.kernel.org, selinux@tycho.nsa.gov
Subject: SELinux & ia64
Date: Tue, 23 Nov 2004 10:13:27 -0500	[thread overview]
Message-ID: <41A35397.1080001@sgi.com> (raw)

SELinux appears to cause warnings while attempting mounts both at 
boot-time and run-time:

kernel unaligned access to 0xa0000002003a0056, ip=0xa0000001002076d0
kernel unaligned access to 0xa0000002003a005e, ip=0xa0000001002076d0
kernel unaligned access to 0xa0000002003a0066, ip=0xa0000001002076d0
kernel unaligned access to 0xa0000002003a006e, ip=0xa0000001002076d0

I've tracked this to the usage of le32_to_cpu in 

security/selinux/ss/policydb.c

The code in question uses:

    len = le32_to_cpu(buf[0]);

and should be

    len = le32_to_cpu(get_unaligned(&buf[0]));

However, this is probably not a good solution as the get_unaligned macro 
can be expensive
on platforms other than ia64. 

I'm tempted to redefine the le32_to_cpu function for policydb.c for the 
ia64 platform, but
before I go down that road I was wondering if anyone had hit this issue 
elsewhere in the kernel?

Prarit.

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

             reply	other threads:[~2004-11-23 15:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-23 15:13 Prarit Bhargava [this message]
2004-11-23 15:13 ` SELinux & ia64 Prarit Bhargava
2004-11-23 16:13 ` Matthew Wilcox
2004-11-23 17:16   ` Prarit Bhargava
2004-11-23 17:16     ` Prarit Bhargava
2004-11-23 18:23 ` Prarit Bhargava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41A35397.1080001@sgi.com \
    --to=prarit@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.