[uml-devel] Re: [patch 1/1] uml: fix some ptrace functions returns values

["Randy.Dunlap" <rddunlap@osdl.org>]

blaisorblade_spam@yahoo.it wrote:
> From: Jeff Dike <jdike@addtoit.com>
> 
> This patch adds ptrace_setfpregs and makes these functions return -errno on
> failure.
> 
> Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade_spam@yahoo.it>
> ---
> 
>  linux-2.6.10-rc-paolo/arch/um/sys-i386/ptrace_user.c |   19 ++++++++++++++++---
>  1 files changed, 16 insertions(+), 3 deletions(-)
> 
> diff -puN arch/um/sys-i386/ptrace_user.c~uml-fix-ptrace-interfaces arch/um/sys-i386/ptrace_user.c
> --- linux-2.6.10-rc/arch/um/sys-i386/ptrace_user.c~uml-fix-ptrace-interfaces	2004-11-24 01:06:35.525806848 +0100
> +++ linux-2.6.10-rc-paolo/arch/um/sys-i386/ptrace_user.c	2004-11-24 01:06:35.528806392 +0100
> @@ -17,17 +17,30 @@
>  
>  int ptrace_getregs(long pid, unsigned long *regs_out)
>  {
> -	return(ptrace(PTRACE_GETREGS, pid, 0, regs_out));
> +	if(ptrace(PTRACE_GETREGS, pid, 0, regs_out) < 0)
> +		return(-errno);
> +	return(0);
>  }
>  
>  int ptrace_setregs(long pid, unsigned long *regs)
>  {
> -	return(ptrace(PTRACE_SETREGS, pid, 0, regs));
> +	if(ptrace(PTRACE_SETREGS, pid, 0, regs) < 0)
> +		return(-errno);
> +	return(0);
>  }
>  
>  int ptrace_getfpregs(long pid, unsigned long *regs)
>  {
> -	return(ptrace(PTRACE_GETFPREGS, pid, 0, regs));
> +	if(ptrace(PTRACE_GETFPREGS, pid, 0, regs) < 0)
> +		return(-errno);
> +	return(0);
> +}
> +
> +int ptrace_setfpregs(long pid, unsigned long *regs)
> +{
> +	if(ptrace(PTRACE_SETFPREGS, pid, 0, regs) < 0)
> +		return(-errno);
> +	return(0);
>  }
>  
>  static void write_debugregs(int pid, unsigned long *regs)

Looks OK except that someone's SPACEBAR is broken (missing)
and there are (unneeded/unwanted) parens on the returns.

-- 
~Randy


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel