All of lore.kernel.org
 help / color / mirror / Atom feed
* bt8xx cleanup
@ 2004-12-02 14:21 C.Y.M
  0 siblings, 0 replies; only message in thread
From: C.Y.M @ 2004-12-02 14:21 UTC (permalink / raw)
  To: Linux-Kernel

Since you just applied those other cleanups from 2.6.10-rc2-bk15, here 
is one more you might want to add.  Thanks.

diff -Nru a/drivers/media/dvb/bt8xx/bt878.h 
b/drivers/media/dvb/bt8xx/bt878.h
--- a/drivers/media/dvb/bt8xx/bt878.h   2004-10-20 08:19:52 -07:00
+++ b/drivers/media/dvb/bt8xx/bt878.h   2004-11-19 05:52:47 -08:00
@@ -102,7 +102,7 @@
         unsigned char revision;
         unsigned int irq;
         unsigned long bt878_adr;
-       unsigned char *bt878_mem; /* function 1 */
+       volatile void __iomem *bt878_mem; /* function 1 */

         volatile u32 finished_block;
         volatile u32 last_block;
@@ -129,17 +129,17 @@
  void bt878_stop(struct bt878 *bt);

  #if defined(__powerpc__)       /* big-endian */
-extern __inline__ void io_st_le32(volatile unsigned *addr, unsigned val)
+extern __inline__ void io_st_le32(volatile unsigned __iomem *addr, 
unsigned val)
  {
         __asm__ __volatile__("stwbrx %1,0,%2":"=m"(*addr):"r"(val),
                              "r"(addr));
         __asm__ __volatile__("eieio":::"memory");
  }

-#define bmtwrite(dat,adr)  io_st_le32((unsigned *)(adr),(dat))
-#define bmtread(adr)       ld_le32((unsigned *)(adr))
+#define bmtwrite(dat,adr)  io_st_le32((adr),(dat))
+#define bmtread(adr)       ld_le32((adr))
  #else
-#define bmtwrite(dat,adr)  writel((dat), (char *) (adr))
+#define bmtwrite(dat,adr)  writel((dat), (adr))
  #define bmtread(adr)       readl(adr)
  #endif

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-12-02 14:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-12-02 14:21 bt8xx cleanup C.Y.M

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.