* Re: [KJ] patches: delete 75 unused files
2004-12-08 15:54 [KJ] patches: delete 75 unused files Domen Puncer
@ 2004-12-08 16:08 ` Greg KH
2004-12-08 16:55 ` Adrian Bunk
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Greg KH @ 2004-12-08 16:08 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 405 bytes --]
On Wed, Dec 08, 2004 at 04:54:39PM +0100, Domen Puncer wrote:
> drivers/pci/hotplug/pcihp_skeleton.c
This is a "skeleton" driver, and is in the tree to be used as an example
for others who want to write a pci hotplug driver. It should stay.
Along those lines, how come you didn't include the usb-skeleton.c file
in your list (it too should stay, but it isn't part of the build...)?
thanks,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [KJ] patches: delete 75 unused files
2004-12-08 15:54 [KJ] patches: delete 75 unused files Domen Puncer
2004-12-08 16:08 ` Greg KH
@ 2004-12-08 16:55 ` Adrian Bunk
2004-12-08 17:05 ` Gustavo Franco
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Adrian Bunk @ 2004-12-08 16:55 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
On Wed, Dec 08, 2004 at 08:08:09AM -0800, Greg KH wrote:
> On Wed, Dec 08, 2004 at 04:54:39PM +0100, Domen Puncer wrote:
> > drivers/pci/hotplug/pcihp_skeleton.c
>
> This is a "skeleton" driver, and is in the tree to be used as an example
> for others who want to write a pci hotplug driver. It should stay.
>
> Along those lines, how come you didn't include the usb-skeleton.c file
> in your list (it too should stay, but it isn't part of the build...)?
If I understand Domen's mail correctly, the mentioning of usb-skeleton
in Documentation/DocBook/writing_usb_driver.tmpl and
drivers/usb/input/xpad.c should be enough for preventing listing it.
> thanks,
>
> greg k-h
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [KJ] patches: delete 75 unused files
2004-12-08 15:54 [KJ] patches: delete 75 unused files Domen Puncer
2004-12-08 16:08 ` Greg KH
2004-12-08 16:55 ` Adrian Bunk
@ 2004-12-08 17:05 ` Gustavo Franco
2004-12-08 17:13 ` Greg KH
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Gustavo Franco @ 2004-12-08 17:05 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
On Wed, 2004-12-08 at 08:08 -0800, Greg KH wrote:
> On Wed, Dec 08, 2004 at 04:54:39PM +0100, Domen Puncer wrote:
> > drivers/pci/hotplug/pcihp_skeleton.c
>
> This is a "skeleton" driver, and is in the tree to be used as an example
> for others who want to write a pci hotplug driver. It should stay.
>
> Along those lines, how come you didn't include the usb-skeleton.c file
> in your list (it too should stay, but it isn't part of the build...)?
>
Hi Greg,
Why these drivers are under the build tree and not in Documentation/
directory? Is it documented anywhere? I'm just curious.
Thanks,
Gustavo Franco -- <stratus@acm.org>
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [KJ] patches: delete 75 unused files
2004-12-08 15:54 [KJ] patches: delete 75 unused files Domen Puncer
` (2 preceding siblings ...)
2004-12-08 17:05 ` Gustavo Franco
@ 2004-12-08 17:13 ` Greg KH
2004-12-08 17:24 ` Gustavo Franco
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Greg KH @ 2004-12-08 17:13 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
On Wed, Dec 08, 2004 at 03:05:20PM -0200, Gustavo Franco wrote:
> On Wed, 2004-12-08 at 08:08 -0800, Greg KH wrote:
> > On Wed, Dec 08, 2004 at 04:54:39PM +0100, Domen Puncer wrote:
> > > drivers/pci/hotplug/pcihp_skeleton.c
> >
> > This is a "skeleton" driver, and is in the tree to be used as an example
> > for others who want to write a pci hotplug driver. It should stay.
> >
> > Along those lines, how come you didn't include the usb-skeleton.c file
> > in your list (it too should stay, but it isn't part of the build...)?
> >
>
> Why these drivers are under the build tree and not in Documentation/
> directory?
Because people don't expect to see source code in the Documentation/
directory :)
I don't really know, that's just the way these types of files have
always been (look at drivers/net/pci-skeleton.c and
drivers/net/isa-skeleton.c as where I got the idea to write
usb-skeleton.c and pcihp_skeleton.c from.)
thanks,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [KJ] patches: delete 75 unused files
2004-12-08 15:54 [KJ] patches: delete 75 unused files Domen Puncer
` (3 preceding siblings ...)
2004-12-08 17:13 ` Greg KH
@ 2004-12-08 17:24 ` Gustavo Franco
2004-12-08 22:15 ` Jim Nelson
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Gustavo Franco @ 2004-12-08 17:24 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]
On Wed, 2004-12-08 at 09:13 -0800, Greg KH wrote:
> On Wed, Dec 08, 2004 at 03:05:20PM -0200, Gustavo Franco wrote:
> > On Wed, 2004-12-08 at 08:08 -0800, Greg KH wrote:
> > > On Wed, Dec 08, 2004 at 04:54:39PM +0100, Domen Puncer wrote:
> > > > drivers/pci/hotplug/pcihp_skeleton.c
> > >
> > > This is a "skeleton" driver, and is in the tree to be used as an example
> > > for others who want to write a pci hotplug driver. It should stay.
> > >
> > > Along those lines, how come you didn't include the usb-skeleton.c file
> > > in your list (it too should stay, but it isn't part of the build...)?
> > >
> >
> > Why these drivers are under the build tree and not in Documentation/
> > directory?
>
> Because people don't expect to see source code in the Documentation/
> directory :)
>
> I don't really know, that's just the way these types of files have
> always been (look at drivers/net/pci-skeleton.c and
> drivers/net/isa-skeleton.c as where I got the idea to write
> usb-skeleton.c and pcihp_skeleton.c from.)
Yes, i see more skel stuff inside the tree and i think that it needs
some discussion or at least don't use skeleton as part of a file name
that will be compiled. AFAIK, we've some of them sitting at
arch/m68k/..., but i can't check atm. What do you think?
--
Gustavo Franco -- <stratus@acm.org>
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [KJ] patches: delete 75 unused files
2004-12-08 15:54 [KJ] patches: delete 75 unused files Domen Puncer
` (4 preceding siblings ...)
2004-12-08 17:24 ` Gustavo Franco
@ 2004-12-08 22:15 ` Jim Nelson
2004-12-09 12:52 ` Gustavo Franco
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Jim Nelson @ 2004-12-08 22:15 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1531 bytes --]
Gustavo Franco wrote:
> On Wed, 2004-12-08 at 09:13 -0800, Greg KH wrote:
>
>>On Wed, Dec 08, 2004 at 03:05:20PM -0200, Gustavo Franco wrote:
>>
>>>On Wed, 2004-12-08 at 08:08 -0800, Greg KH wrote:
>>>
>>>>On Wed, Dec 08, 2004 at 04:54:39PM +0100, Domen Puncer wrote:
>>>>
>>>>> drivers/pci/hotplug/pcihp_skeleton.c
>>>>
>>>>This is a "skeleton" driver, and is in the tree to be used as an example
>>>>for others who want to write a pci hotplug driver. It should stay.
>>>>
>>>>Along those lines, how come you didn't include the usb-skeleton.c file
>>>>in your list (it too should stay, but it isn't part of the build...)?
>>>>
>>>
>>>Why these drivers are under the build tree and not in Documentation/
>>>directory?
>>
>>Because people don't expect to see source code in the Documentation/
>>directory :)
>>
>>I don't really know, that's just the way these types of files have
>>always been (look at drivers/net/pci-skeleton.c and
>>drivers/net/isa-skeleton.c as where I got the idea to write
>>usb-skeleton.c and pcihp_skeleton.c from.)
>
>
> Yes, i see more skel stuff inside the tree and i think that it needs
> some discussion or at least don't use skeleton as part of a file name
> that will be compiled. AFAIK, we've some of them sitting at
> arch/m68k/..., but i can't check atm. What do you think?
>
> --
> Gustavo Franco -- <stratus@acm.org>
>
>
Why not make a Documentation/driver-skeletons.txt? I can write it, if everyone
can point me in the direction of where all the skeleton and example files are.
Jim
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [KJ] patches: delete 75 unused files
2004-12-08 15:54 [KJ] patches: delete 75 unused files Domen Puncer
` (5 preceding siblings ...)
2004-12-08 22:15 ` Jim Nelson
@ 2004-12-09 12:52 ` Gustavo Franco
2004-12-10 10:43 ` maximilian attems
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Gustavo Franco @ 2004-12-09 12:52 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 916 bytes --]
On Wed, 2004-12-08 at 17:15 -0500, Jim Nelson wrote:
> [...]
> >
> > Yes, i see more skel stuff inside the tree and i think that it needs
> > some discussion or at least don't use skeleton as part of a file name
> > that will be compiled. AFAIK, we've some of them sitting at
> > arch/m68k/..., but i can't check atm. What do you think?
> >
>
>
> Why not make a Documentation/driver-skeletons.txt? I can write it, if everyone
> can point me in the direction of where all the skeleton and example files are.
I agree, you're free to submit it but i've no idea if it will be
accepted.
`find . -name *skel*` under the tree is a good guess, but you'll see
some files that aren't skeletons. Actually, we can't say that all
skeletons are with *skeleton* in their filenames, you can start the
documention with these above and after that ask at lkml for more.
Hope that helps,
Gustavo Franco -- <stratus@acm.org>
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [KJ] patches: delete 75 unused files
2004-12-08 15:54 [KJ] patches: delete 75 unused files Domen Puncer
` (6 preceding siblings ...)
2004-12-09 12:52 ` Gustavo Franco
@ 2004-12-10 10:43 ` maximilian attems
2004-12-10 10:44 ` maximilian attems
2004-12-10 10:51 ` maximilian attems
9 siblings, 0 replies; 11+ messages in thread
From: maximilian attems @ 2004-12-10 10:43 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
On Thu, 09 Dec 2004, Gustavo Franco wrote:
> On Wed, 2004-12-08 at 17:15 -0500, Jim Nelson wrote:
> > [...]
> > >
> > > Yes, i see more skel stuff inside the tree and i think that it needs
> > > some discussion or at least don't use skeleton as part of a file name
> > > that will be compiled. AFAIK, we've some of them sitting at
> > > arch/m68k/..., but i can't check atm. What do you think?
> > >
> >
> >
> > Why not make a Documentation/driver-skeletons.txt? I can write it, if everyone
> > can point me in the direction of where all the skeleton and example files are.
>
> I agree, you're free to submit it but i've no idea if it will be
> accepted.
as greg already said, you won't expect code under Documentation.
i won't push such patches.
please pick something usefull.
--
maks
kernel janitor http://janitor.kernelnewbies.org/
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [KJ] patches: delete 75 unused files
2004-12-08 15:54 [KJ] patches: delete 75 unused files Domen Puncer
` (7 preceding siblings ...)
2004-12-10 10:43 ` maximilian attems
@ 2004-12-10 10:44 ` maximilian attems
2004-12-10 10:51 ` maximilian attems
9 siblings, 0 replies; 11+ messages in thread
From: maximilian attems @ 2004-12-10 10:44 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 151 bytes --]
On Wed, 08 Dec 2004, Domen Puncer wrote:
> drivers/media/dvb/frontends/sp887x_firm.h
this one even survived in the debian kernel.
*funny*
--
maks
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [KJ] patches: delete 75 unused files
2004-12-08 15:54 [KJ] patches: delete 75 unused files Domen Puncer
` (8 preceding siblings ...)
2004-12-10 10:44 ` maximilian attems
@ 2004-12-10 10:51 ` maximilian attems
9 siblings, 0 replies; 11+ messages in thread
From: maximilian attems @ 2004-12-10 10:51 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
On Thu, 09 Dec 2004, Gustavo Franco wrote:
> On Wed, 2004-12-08 at 17:15 -0500, Jim Nelson wrote:
> >
> >
> > Why not make a Documentation/driver-skeletons.txt? I can write it, if everyone
> > can point me in the direction of where all the skeleton and example files are.
>
> I agree, you're free to submit it but i've no idea if it will be
> accepted.
please forget my previous mail. misread end of the thread. ;-)
that's a nice idea.
--
maks
kernel janitor http://janitor.kernelnewbies.org/
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 11+ messages in thread