All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Dittmer <jdittmer@ppp0.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] Re: [PATCH] lcd: replace cli()/sti() with
Date: Sat, 18 Dec 2004 08:54:49 +0000	[thread overview]
Message-ID: <41C3F059.7000804@ppp0.net> (raw)
In-Reply-To: <41C380D0.9020001@ppp0.net>

Matthew Wilcox wrote:
> On Fri, Dec 17, 2004 at 10:02:16PM -0500, Jim Nelson wrote:
> 
>>Jan Dittmer wrote:
>>
>>>James Nelson wrote:
>>>
>>>
>>>>Remove the cli()/sti() calls in drivers/char/lcd.c
>>>
>>>
>>>Why is this cli() there in the first place? ioctl is already
>>>called under lock_kernel.
>>
>>First - a warning.  Newbie on the loose, running around, asking for a whack 
>>with the cluebat.
> 
> 
> OK.  Quick lesson (for both of you actually; Jan's response wasn't accurate).

Thanks.

> So you still need to disable interrupts, even if you're running under the
> BKL -- interrupt routines can't acquire the BKL (because it's magic) and
> acquiring the BKL doesn't disable interrupts.

But still, two ioctl()s can't run in parallel, can they? The driver isn't
using any interrupts (I'm aware that this asumption isn't necessarily
true in the future due to ioctl_unlocked work, etc.).

Jan
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2004-12-18  8:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-17 23:59 [KJ] [PATCH] lcd: replace cli()/sti() with James Nelson
2004-12-17 23:59 ` [PATCH] lcd: replace cli()/sti() with spin_lock_irqsave()/spin_unlock_irqrestore() James Nelson
2004-12-18  0:58 ` [KJ] Re: [PATCH] lcd: replace cli()/sti() with Jan Dittmer
2004-12-18  0:58   ` [PATCH] lcd: replace cli()/sti() with spin_lock_irqsave()/spin_unlock_irqrestore() Jan Dittmer
2004-12-18  3:02   ` [KJ] Re: [PATCH] lcd: replace cli()/sti() with Jim Nelson
2004-12-18  3:02     ` [PATCH] lcd: replace cli()/sti() with spin_lock_irqsave()/spin_unlock_irqrestore() Jim Nelson
2004-12-18  4:40     ` [KJ] Re: [PATCH] lcd: replace cli()/sti() with Matthew Wilcox
2004-12-18  4:40       ` [KJ] Re: [PATCH] lcd: replace cli()/sti() with spin_lock_irqsave()/spin_unlock_irqrestore() Matthew Wilcox
2004-12-18  8:54   ` Jan Dittmer [this message]
2004-12-18 14:47   ` [KJ] Re: [PATCH] lcd: replace cli()/sti() with Matthew Wilcox
2004-12-18  4:15 ` [KJ] " Matthew Wilcox
2004-12-18  4:15   ` [KJ] [PATCH] lcd: replace cli()/sti() with spin_lock_irqsave()/spin_unlock_irqrestore() Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41C3F059.7000804@ppp0.net \
    --to=jdittmer@ppp0.net \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.