From: Jim Nelson <james4765@verizon.net>
To: Jan Dittmer <jdittmer@ppp0.net>
Cc: kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: [KJ] Re: [PATCH] lcd: replace cli()/sti() with
Date: Sat, 18 Dec 2004 03:02:16 +0000 [thread overview]
Message-ID: <41C39DB8.6050403@verizon.net> (raw)
In-Reply-To: <41C380D0.9020001@ppp0.net>
[-- Attachment #1: Type: text/plain, Size: 1865 bytes --]
Jan Dittmer wrote:
> James Nelson wrote:
>
>>Remove the cli()/sti() calls in drivers/char/lcd.c
>
>
> Why is this cli() there in the first place? ioctl is already
> called under lock_kernel.
>
>
First - a warning. Newbie on the loose, running around, asking for a whack with
the cluebat.
I had seen other drivers that had cli()/sti() calls in the ioctl functions. So,
that is wrong? Should all of those cli()/sti() calls be removed?
Just to site things properly in my mind, was it always the case that ioctl is
called under lock_kernel, or is this a relatively recent (2.3+) development? Some
of the *really* abandoned drivers haven't been touched in at least that long.
>>Signed-off-by: James Nelson <james4765@gmail.com>
>>
>>diff -urN --exclude='*~' linux-2.6.10-rc3-mm1-original/drivers/char/lcd.c linux-2.6.10-rc3-mm1/drivers/char/lcd.c
>>--- linux-2.6.10-rc3-mm1-original/drivers/char/lcd.c 2004-12-03 16:53:42.000000000 -0500
>>+++ linux-2.6.10-rc3-mm1/drivers/char/lcd.c 2004-12-17 18:57:10.760197439 -0500
>>@@ -33,6 +33,8 @@
>>
>> #include "lcd.h"
>>
>>+static spinlock_t lcd_lock = SPIN_LOCK_UNLOCKED;
>>+
>> static int lcd_ioctl(struct inode *inode, struct file *file,
>> unsigned int cmd, unsigned long arg);
>>
>>@@ -464,14 +466,13 @@
>> }
>>
>> printk("Churning and Burning -");
>>- save_flags(flags);
>> for (i = 0; i < FLASH_SIZE; i = i + 128) {
>>
>> if (copy_from_user
>> (rom, display.RomImage + i, 128))
>> return -EFAULT;
>
>
> The driver is leaking memory, rom is not freed in this case.
Erm. Didn't notice that.
>
> Jan
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
WARNING: multiple messages have this Message-ID (diff)
From: Jim Nelson <james4765@verizon.net>
To: Jan Dittmer <jdittmer@ppp0.net>
Cc: kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lcd: replace cli()/sti() with spin_lock_irqsave()/spin_unlock_irqrestore()
Date: Fri, 17 Dec 2004 22:02:16 -0500 [thread overview]
Message-ID: <41C39DB8.6050403@verizon.net> (raw)
In-Reply-To: <41C380D0.9020001@ppp0.net>
Jan Dittmer wrote:
> James Nelson wrote:
>
>>Remove the cli()/sti() calls in drivers/char/lcd.c
>
>
> Why is this cli() there in the first place? ioctl is already
> called under lock_kernel.
>
>
First - a warning. Newbie on the loose, running around, asking for a whack with
the cluebat.
I had seen other drivers that had cli()/sti() calls in the ioctl functions. So,
that is wrong? Should all of those cli()/sti() calls be removed?
Just to site things properly in my mind, was it always the case that ioctl is
called under lock_kernel, or is this a relatively recent (2.3+) development? Some
of the *really* abandoned drivers haven't been touched in at least that long.
>>Signed-off-by: James Nelson <james4765@gmail.com>
>>
>>diff -urN --exclude='*~' linux-2.6.10-rc3-mm1-original/drivers/char/lcd.c linux-2.6.10-rc3-mm1/drivers/char/lcd.c
>>--- linux-2.6.10-rc3-mm1-original/drivers/char/lcd.c 2004-12-03 16:53:42.000000000 -0500
>>+++ linux-2.6.10-rc3-mm1/drivers/char/lcd.c 2004-12-17 18:57:10.760197439 -0500
>>@@ -33,6 +33,8 @@
>>
>> #include "lcd.h"
>>
>>+static spinlock_t lcd_lock = SPIN_LOCK_UNLOCKED;
>>+
>> static int lcd_ioctl(struct inode *inode, struct file *file,
>> unsigned int cmd, unsigned long arg);
>>
>>@@ -464,14 +466,13 @@
>> }
>>
>> printk("Churning and Burning -");
>>- save_flags(flags);
>> for (i = 0; i < FLASH_SIZE; i = i + 128) {
>>
>> if (copy_from_user
>> (rom, display.RomImage + i, 128))
>> return -EFAULT;
>
>
> The driver is leaking memory, rom is not freed in this case.
Erm. Didn't notice that.
>
> Jan
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2004-12-18 3:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-17 23:59 [KJ] [PATCH] lcd: replace cli()/sti() with James Nelson
2004-12-17 23:59 ` [PATCH] lcd: replace cli()/sti() with spin_lock_irqsave()/spin_unlock_irqrestore() James Nelson
2004-12-18 0:58 ` [KJ] Re: [PATCH] lcd: replace cli()/sti() with Jan Dittmer
2004-12-18 0:58 ` [PATCH] lcd: replace cli()/sti() with spin_lock_irqsave()/spin_unlock_irqrestore() Jan Dittmer
2004-12-18 3:02 ` Jim Nelson [this message]
2004-12-18 3:02 ` Jim Nelson
2004-12-18 4:40 ` [KJ] Re: [PATCH] lcd: replace cli()/sti() with Matthew Wilcox
2004-12-18 4:40 ` [KJ] Re: [PATCH] lcd: replace cli()/sti() with spin_lock_irqsave()/spin_unlock_irqrestore() Matthew Wilcox
2004-12-18 8:54 ` [KJ] Re: [PATCH] lcd: replace cli()/sti() with Jan Dittmer
2004-12-18 14:47 ` Matthew Wilcox
2004-12-18 4:15 ` [KJ] " Matthew Wilcox
2004-12-18 4:15 ` [KJ] [PATCH] lcd: replace cli()/sti() with spin_lock_irqsave()/spin_unlock_irqrestore() Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41C39DB8.6050403@verizon.net \
--to=james4765@verizon.net \
--cc=jdittmer@ppp0.net \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.