* domain setmaxmen in KB or bytes?
@ 2004-12-27 16:00 Jacob Gorm Hansen
0 siblings, 0 replies; only message in thread
From: Jacob Gorm Hansen @ 2004-12-27 16:00 UTC (permalink / raw)
To: xen-devel@lists.sourceforge.net
hi,
the maxmem parameter to DOM0_SETDOMAINMAXMEM is called max_memkb,
indicating that it should be in kilobytes, but looking at the code in
xen/common/dom0_ops.c:
case DOM0_SETDOMAINMAXMEM:
{
struct domain *d;
ret = -ESRCH;
d = find_domain_by_id( op->u.setdomainmaxmem.domain );
if ( d != NULL )
{
d->max_pages =
(op->u.setdomainmaxmem.max_memkb+PAGE_SIZE-1)>> PAGE_SHIFT;
put_domain(d);
ret = 0;
}
}
break;
It seems the value is treated as being in bytes? Bug or feature?
best,
Jacob
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-12-27 16:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-12-27 16:00 domain setmaxmen in KB or bytes? Jacob Gorm Hansen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.