Re: [PATCH] get/set FAT filesystem attribute bits

["H. Peter Anvin" <hpa@zytor.com>]

OGAWA Hirofumi wrote:

> "H. Peter Anvin" <hpa@zytor.com> writes:
> 
> 
>>-	inode->i_ctime.tv_nsec = de->ctime_ms * 1000000;
>>-	MSDOS_I(inode)->i_ctime_ms = de->ctime_ms;
>>+	inode->i_ctime.tv_nsec = de->ctime_ms * 1000000U;
> 
> Actually, the ->ctime_ms is not mili seconds. The valid range is 0-199 (*10ms).
> (And ->ctime is started from 2 seconds)
> 

D'oh!  They probably should be renamed _cs (centiseconds ;)

> 
>>-		raw_entry->ctime_ms = MSDOS_I(inode)->i_ctime_ms; /* use i_ctime.tv_nsec? */
>>+		raw_entry->ctime_ms = inode->i_ctime.tv_nsec / 1000000U;
> 
> 
> BTW, do you already have any plan to use this ioctls?
> 

Yes, I wanted to use them for the syslinux installer.

	-hpa