From: Andreas Steinmetz <ast@domdv.de>
To: Andi Kleen <ak@muc.de>
Cc: Zwane Mwaikambo <zwane@arm.linux.org.uk>,
Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86_64: Notify user of MCE events (updated)
Date: Sun, 09 Jan 2005 19:30:56 +0100 [thread overview]
Message-ID: <41E17860.1040100@domdv.de> (raw)
In-Reply-To: <m1fz1av5am.fsf@muc.de>
Andi Kleen wrote:
> Zwane Mwaikambo <zwane@arm.linux.org.uk> writes:
>
>>+ */
>>+ if (notify_user && console_logged) {
>>+ notify_user = 0;
>>+ clear_bit(0, &console_logged);
>>+ printk(KERN_EMERG "Machine check exception logged\n");
>
>
> Another suggestion: don't make this KERN_EMERG. Make it KERN_INFO.
> Logged errors are usually correct, so there is no need for an
> emergency.
Just asking:
How about KERN_NOTICE? KERN_INFO is in my opinion too easily lost in the
syslog noise. Personally I'm logging KERN_INFO just to console,
KERN_NOTICE however to file.
An MCE event would suit the description "normal but significant
condition" of KERN_NOTICE as far as I can see.
--
Andreas Steinmetz SPAMmers use robotrap@domdv.de
next prev parent reply other threads:[~2005-01-09 18:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-09 4:29 [PATCH] x86_64: Notify user of MCE events Zwane Mwaikambo
2005-01-09 16:44 ` Andi Kleen
2005-01-09 17:10 ` [PATCH] x86_64: Notify user of MCE events (updated) Zwane Mwaikambo
2005-01-09 18:14 ` Andi Kleen
2005-01-09 18:20 ` [PATCH] x86_64: Notify user of MCE events (updated 2) Zwane Mwaikambo
2005-01-09 18:27 ` [PATCH] x86_64: Notify user of MCE events (updated) Zwane Mwaikambo
2005-01-09 18:30 ` Andreas Steinmetz [this message]
2005-01-09 18:40 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41E17860.1040100@domdv.de \
--to=ast@domdv.de \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.