From: Andi Kleen <ak@muc.de>
To: Zwane Mwaikambo <zwane@arm.linux.org.uk>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86_64: Notify user of MCE events.
Date: Sun, 09 Jan 2005 17:44:54 +0100 [thread overview]
Message-ID: <m1sm5av9fd.fsf@muc.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0501082121380.13639@montezuma.fsmlabs.com> (Zwane Mwaikambo's message of "Sat, 8 Jan 2005 21:29:41 -0700 (MST)")
Zwane Mwaikambo <zwane@arm.linux.org.uk> writes:
> +
> + if (!test_and_set_bit(0, &console_logged))
> + notify_user = 1;
> }
>
> static void print_mce(struct mce *m)
> @@ -252,6 +258,12 @@ static void mcheck_timer(void *data)
> {
> on_each_cpu(mcheck_check_cpu, NULL, 1, 1);
> schedule_delayed_work(&mcheck_work, check_interval * HZ);
> +
> + if (notify_user && console_logged) {
Perhaps a comment here that the race is harmless?
> + notify_user = 0;
> + clear_bit(0, &console_logged);
> + printk(KERN_EMERG "Machine check exception logged, run mcelog\n");
I would drop the "run mcelog". It's misleading if mcelog is already
running in cron as it should.
-Andi
next prev parent reply other threads:[~2005-01-09 16:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-09 4:29 [PATCH] x86_64: Notify user of MCE events Zwane Mwaikambo
2005-01-09 16:44 ` Andi Kleen [this message]
2005-01-09 17:10 ` [PATCH] x86_64: Notify user of MCE events (updated) Zwane Mwaikambo
2005-01-09 18:14 ` Andi Kleen
2005-01-09 18:20 ` [PATCH] x86_64: Notify user of MCE events (updated 2) Zwane Mwaikambo
2005-01-09 18:27 ` [PATCH] x86_64: Notify user of MCE events (updated) Zwane Mwaikambo
2005-01-09 18:30 ` Andreas Steinmetz
2005-01-09 18:40 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1sm5av9fd.fsf@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.