Re: [PATCH 4/4] conntrack ftp helper modification to use new infrastrure

[Pablo Neira <pablo@eurodev.net>]

Patrick McHardy wrote:

>> #define MAX_PORTS 8
>> static int ports[MAX_PORTS];
>> static int ports_c;
>> @@ -56,30 +56,35 @@
>>     char skip;
>>     char term;
>>     enum ip_ct_ftp_type ftptype;
>> +    struct nf_string_match *sm;
>>  
>>
>
> Why is is part of struct ftpsearch ? One struct nf_string_match per 
> helper
> should be enough as long as we take the global lock.


because the ftp helper looks for four different patterns. The goodshift 
and badshift arrays required by the boyer-moore algorithm are different 
for every pattern.

Actually, I started a version using lists of nf_string_match to look for 
a set of patterns iteratively but I finally decided to simplify the 
thing. If someone finds this feature interesting I could recover it in 
future.

--
Pablo