All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira <pablo@eurodev.net>
Cc: Harald Welte <laforge@netfilter.org>,
	Netfilter Development Mailinglist
	<netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH 4/4] conntrack ftp helper modification to use new infrastrure
Date: Mon, 10 Jan 2005 00:46:41 +0100	[thread overview]
Message-ID: <41E1C261.6050100@trash.net> (raw)
In-Reply-To: <41E1BEBC.3030703@eurodev.net>

Pablo Neira wrote:

> Patrick McHardy wrote:
>
>> Why is is part of struct ftpsearch ? One struct nf_string_match per 
>> helper
>> should be enough as long as we take the global lock.
>
>
> because the ftp helper looks for four different patterns. The 
> goodshift and badshift arrays required by the boyer-moore algorithm 
> are different for every pattern.

Thanks for the explanation.

>
> Actually, I started a version using lists of nf_string_match to look 
> for a set of patterns iteratively but I finally decided to simplify 
> the thing. If someone finds this feature interesting I could recover 
> it in future.

Since the FTP helper is currently the only possible user of such a feature
I think the current way is fine.

Regards
Patrick

  reply	other threads:[~2005-01-09 23:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-09 22:23 [PATCH 4/4] conntrack ftp helper modification to use new infrastrure Pablo Neira
2005-01-09 23:20 ` Patrick McHardy
2005-01-09 23:31   ` Pablo Neira
2005-01-09 23:46     ` Patrick McHardy [this message]
2005-02-01 11:01       ` Harald Welte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41E1C261.6050100@trash.net \
    --to=kaber@trash.net \
    --cc=laforge@netfilter.org \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=pablo@eurodev.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.