From: Steve Longerbeam <stevel@mvista.com>
To: Ray Bryant <raybry@sgi.com>
Cc: Andi Kleen <ak@muc.de>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: page migration patchset
Date: Tue, 11 Jan 2005 12:59:18 -0800 [thread overview]
Message-ID: <41E43E26.2060303@mvista.com> (raw)
In-Reply-To: <41E4295F.1010909@sgi.com>
Ray Bryant wrote:
> Steve Longerbeam wrote:
>
>
>>
>> isn't this already taken care of? read_swap_cache_async() is given
>> a vma, and passes it to alloc_page_vma(). So if you have earlier
>> changed the policy for that vma, the new policy will be used
>> when allocating the page during the swap in.
>>
>> Steve
>>
>
> What if the policy associated with a vma is the default policy?
then read_swap_cache_async() would probably allocate pages for
the swap readin from the wrong nodes, but then migrate_process_pages
would move those to the correct nodes later. But if migrate_process_pages
is called *before* swap readin, the policies will be changed and
read_swap_cache_async() would allocate from the correct nodes.
Maybe I'm missing something, but let me rephrase my argument.
If read_swap_cache_async() is called *before* the vma policies are
changed, they will most likely be allocated from the wrong nodes but
will then be migrated to the correct nodes during the
policy-change-and-page-migrate syscall, and if the swap readin happens
*after* the syscall, the page allocations will use the new policies.
Steve
WARNING: multiple messages have this Message-ID (diff)
From: Steve Longerbeam <stevel@mvista.com>
To: Ray Bryant <raybry@sgi.com>
Cc: Andi Kleen <ak@muc.de>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: page migration patchset
Date: Tue, 11 Jan 2005 12:59:18 -0800 [thread overview]
Message-ID: <41E43E26.2060303@mvista.com> (raw)
In-Reply-To: <41E4295F.1010909@sgi.com>
Ray Bryant wrote:
> Steve Longerbeam wrote:
>
>
>>
>> isn't this already taken care of? read_swap_cache_async() is given
>> a vma, and passes it to alloc_page_vma(). So if you have earlier
>> changed the policy for that vma, the new policy will be used
>> when allocating the page during the swap in.
>>
>> Steve
>>
>
> What if the policy associated with a vma is the default policy?
then read_swap_cache_async() would probably allocate pages for
the swap readin from the wrong nodes, but then migrate_process_pages
would move those to the correct nodes later. But if migrate_process_pages
is called *before* swap readin, the policies will be changed and
read_swap_cache_async() would allocate from the correct nodes.
Maybe I'm missing something, but let me rephrase my argument.
If read_swap_cache_async() is called *before* the vma policies are
changed, they will most likely be allocated from the wrong nodes but
will then be migrated to the correct nodes during the
policy-change-and-page-migrate syscall, and if the swap readin happens
*after* the syscall, the page allocations will use the new policies.
Steve
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2005-01-11 20:59 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-05 0:32 page migration patchset Ray Bryant
2005-01-05 0:32 ` Ray Bryant
2005-01-05 2:07 ` Andi Kleen
2005-01-05 2:07 ` Andi Kleen
2005-01-05 3:20 ` Ray Bryant
2005-01-05 3:20 ` Ray Bryant
2005-01-05 18:41 ` Steve Longerbeam
2005-01-05 18:41 ` Steve Longerbeam
2005-01-05 19:23 ` Ray Bryant
2005-01-05 19:23 ` Ray Bryant
2005-01-05 23:00 ` Steve Longerbeam
2005-01-05 23:16 ` Ray Bryant
2005-01-05 23:16 ` Ray Bryant
2005-01-05 20:55 ` Hugh Dickins
2005-01-05 20:55 ` Hugh Dickins
[not found] ` <41DC7EAD.8010407@mvista.com>
2005-01-06 14:43 ` Andi Kleen
2005-01-06 14:43 ` Andi Kleen
2005-01-06 16:00 ` Ray Bryant
2005-01-06 16:00 ` Ray Bryant
2005-01-06 17:50 ` Christoph Lameter
2005-01-06 17:50 ` Christoph Lameter
2005-01-06 19:29 ` Andi Kleen
2005-01-06 19:29 ` Andi Kleen
2005-01-06 22:30 ` William Lee Irwin III
2005-01-06 22:30 ` William Lee Irwin III
2005-01-06 23:08 ` Andrew Morton
2005-01-06 23:08 ` Andrew Morton
2005-01-06 23:15 ` William Lee Irwin III
2005-01-06 23:15 ` William Lee Irwin III
2005-01-06 23:21 ` Ray Bryant
2005-01-06 23:21 ` Ray Bryant
2005-01-06 23:35 ` William Lee Irwin III
2005-01-06 23:35 ` William Lee Irwin III
2005-01-06 23:53 ` Anton Blanchard
2005-01-06 23:53 ` Anton Blanchard
2005-01-07 0:06 ` William Lee Irwin III
2005-01-07 0:06 ` William Lee Irwin III
2005-01-07 0:31 ` Andi Kleen
2005-01-07 0:31 ` Andi Kleen
2005-01-06 23:43 ` Steve Longerbeam
2005-01-06 23:43 ` Steve Longerbeam
2005-01-06 23:58 ` William Lee Irwin III
2005-01-06 23:58 ` William Lee Irwin III
2005-01-11 15:38 ` Ray Bryant
2005-01-11 15:38 ` Ray Bryant
2005-01-11 19:00 ` Steve Longerbeam
2005-01-11 19:00 ` Steve Longerbeam
2005-01-11 19:30 ` Ray Bryant
2005-01-11 19:30 ` Ray Bryant
2005-01-11 20:59 ` Steve Longerbeam [this message]
2005-01-11 20:59 ` Steve Longerbeam
2005-01-12 12:35 ` Robin Holt
2005-01-12 12:35 ` Robin Holt
2005-01-12 18:12 ` Hugh Dickins
2005-01-12 18:12 ` Hugh Dickins
2005-01-12 18:45 ` Ray Bryant
2005-01-12 18:45 ` Ray Bryant
2005-01-12 18:53 ` Andrew Morton
2005-01-12 18:53 ` Andrew Morton
2005-01-14 13:55 ` swapspace layout improvements advocacy Tim Schmielau
2005-01-14 18:15 ` Andrew Morton
2005-01-14 22:52 ` Barry K. Nathan
2005-01-15 0:33 ` Alan Cox
2005-01-15 2:26 ` Tim Schmielau
2005-01-15 8:55 ` Pasi Savolainen
-- strict thread matches above, loose matches on Subject: below --
2005-01-06 20:59 page migration patchset Ray Bryant
2005-01-06 20:59 ` Ray Bryant
2005-01-06 23:04 ` Andi Kleen
2005-01-06 23:04 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41E43E26.2060303@mvista.com \
--to=stevel@mvista.com \
--cc=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=raybry@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.