make dist and python files

make dist and python files

[Arun Sharma]

In the xeno-unstable tree,

# make install

populates python files in /usr/lib/python2.3/site-packages/xen

However,

# make dist

populates them in

dist/install/lib/python

For people trying to package up Xen into an installable object (rpm/deb 
whatever) this creates a problem.

So my question is, why not have

# make dist

also populate

dist/install/usr/lib/python2.3/site-packages/xen

Of course, this won't work for situations where the build machine and 
the target machine have a different version of python.

Relevant snippet from tools/python/Makefile:

install: all
         if [ "$(prefix)" = "" ]; then                   \
             python setup.py install;                    \
         elif [ "$(dist)" = "yes" ]; then                \
             python setup.py install --home="$(prefix)"; \
         else                                            \
             python setup.py install --root="$(prefix)"; \
         fi

	-Arun



-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Re: make dist and python files

[Keir Fraser]

> So my question is, why not have
> 
> # make dist
> 
> also populate
> 
> dist/install/usr/lib/python2.3/site-packages/xen
> 
> Of course, this won't work for situations where the build machine and 
> the target machine have a different version of python.

Exactly.

All our tools add /lib/python to their library search path, so if you
install by copying to dist/* to / then things will work -- no need to
manually add /lib/python to your search path.

 -- Keir


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Re: make dist and python files

[Arun Sharma]

Keir Fraser wrote:
>>So my question is, why not have
>>
>># make dist
>>
>>also populate
>>
>>dist/install/usr/lib/python2.3/site-packages/xen
>>
>>Of course, this won't work for situations where the build machine and 
>>the target machine have a different version of python.
> 
> 
> Exactly.
> 
> All our tools add /lib/python to their library search path, so if you
> install by copying to dist/* to / then things will work -- no need to
> manually add /lib/python to your search path.

Then why not have just one place to install files for both the install 
and dist targets?

Also, I wonder what the distro hackers and FHS experts on the list have 
to say about the target directory (/lib/python)?

	-Arun


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Re: make dist and python files

[Keir Fraser]

> > Exactly.
> > 
> > All our tools add /lib/python to their library search path, so if you
> > install by copying to dist/* to / then things will work -- no need to
> > manually add /lib/python to your search path.
> 
> Then why not have just one place to install files for both the install 
> and dist targets?
> 
> Also, I wonder what the distro hackers and FHS experts on the list have 
> to say about the target directory (/lib/python)?

Possibly something like /usr/lib/xen/python/... would be more in
keeping with where we install other stuff from dist.

Possibly the install target should place the files in the same place,
rather than in the Python installation's default site-package
directory. 

This is very easy to change if we want to make the two targets install
to the same directory path.

 -- Keir


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Re: make dist and python files

[Adam Heath]

On Tue, 11 Jan 2005, Arun Sharma wrote:

>
> In the xeno-unstable tree,
>
> # make install
>
> populates python files in /usr/lib/python2.3/site-packages/xen
>
> However,
>
> # make dist
>
> populates them in
>
> dist/install/lib/python
>
> For people trying to package up Xen into an installable object (rpm/deb
> whatever) this creates a problem.
>
> So my question is, why not have
>
> # make dist
>
> also populate
>
> dist/install/usr/lib/python2.3/site-packages/xen
>
> Of course, this won't work for situations where the build machine and
> the target machine have a different version of python.

No, the proper way is to have make install only, and set DESTDIR when you want
to install into a separate tree.

I have patches that do this consistently to all makefiles(I made them when
producing the official package for Debian).  I'll try to send them to this
list this week.


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt