All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Nelson <james4765@cwazy.co.uk>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org,
	akpm@osdl.org
Subject: [KJ] Re: [PATCH 0/13] remove cli()/sti() in drivers/char/*
Date: Sun, 16 Jan 2005 20:13:29 +0000	[thread overview]
Message-ID: <41EACAE9.9090505@cwazy.co.uk> (raw)
In-Reply-To: <41EABFC5.3060002@osdl.org>

[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]

Randy.Dunlap wrote:
> James Nelson wrote:
> 
>> This series of patches removes the last 
>> cli()/sti()/save_flags()/restore_flags()
>> function calls in drivers/char.
> 
> 
> to what end?
> 
> I guess I don't get it.  What makes these drivers SMP-safe now?
> 
> Or is this series of patches only done to kill off the use
> of deprecated functions?  If that's the case, they could
> easily give someone the (false) expectation that the drivers
> are SMP-safe, couldn't they?  Well, ftape (for one) is still
> marked as BROKEN_ON_SMP, but will people know why it's
> marked that way?
> 
> Have you read Documentation/cli-sti-removal.txt ?
> 
I have.  This is just to get rid of the deprecated functions - most of this stuff 
is already marked BROKEN_ON_SMP (stallion, serial_tx3912, epca, esp, istallion, 
riscom8, ftape, pcxx and moxa), and ite_gpio.c is a driver for a UP system board.

Maybe later (when I have more of an understanding of serial_core, and major driver 
overhaul) I can tackle actually fixing them, but right now, I'm just doing cleanup 
work.

Jim

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Jim Nelson <james4765@cwazy.co.uk>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org,
	akpm@osdl.org
Subject: Re: [PATCH 0/13] remove cli()/sti() in drivers/char/*
Date: Sun, 16 Jan 2005 15:13:29 -0500	[thread overview]
Message-ID: <41EACAE9.9090505@cwazy.co.uk> (raw)
In-Reply-To: <41EABFC5.3060002@osdl.org>

Randy.Dunlap wrote:
> James Nelson wrote:
> 
>> This series of patches removes the last 
>> cli()/sti()/save_flags()/restore_flags()
>> function calls in drivers/char.
> 
> 
> to what end?
> 
> I guess I don't get it.  What makes these drivers SMP-safe now?
> 
> Or is this series of patches only done to kill off the use
> of deprecated functions?  If that's the case, they could
> easily give someone the (false) expectation that the drivers
> are SMP-safe, couldn't they?  Well, ftape (for one) is still
> marked as BROKEN_ON_SMP, but will people know why it's
> marked that way?
> 
> Have you read Documentation/cli-sti-removal.txt ?
> 
I have.  This is just to get rid of the deprecated functions - most of this stuff 
is already marked BROKEN_ON_SMP (stallion, serial_tx3912, epca, esp, istallion, 
riscom8, ftape, pcxx and moxa), and ite_gpio.c is a driver for a UP system board.

Maybe later (when I have more of an understanding of serial_core, and major driver 
overhaul) I can tackle actually fixing them, but right now, I'm just doing cleanup 
work.

Jim

  reply	other threads:[~2005-01-16 20:13 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-16 13:52 [PATCH 0/13] remove cli()/sti() in drivers/char/* James Nelson
2005-01-16 13:52 ` [PATCH 1/13] epca: remove cli()/sti() in drivers/char/epca.c James Nelson
2005-01-16 13:52 ` [PATCH 2/13] esp: remove cli()/sti() in drivers/char/esp.c James Nelson
2005-01-16 13:52 ` [PATCH 3/13] ftape: remove cli()/sti() in drivers/char/ftape/lowlevel/ftape-format.c James Nelson
2005-01-16 21:10   ` [KJ] Re: [PATCH 3/13] ftape: remove cli()/sti() in Alan Cox
2005-01-16 21:10     ` [PATCH 3/13] ftape: remove cli()/sti() in drivers/char/ftape/lowlevel/ftape-format.c Alan Cox
2005-01-16 13:52 ` [PATCH 4/13] ftape: remove cli()/sti() in drivers/char/ftape/lowlevel/ftape-io.c James Nelson
2005-01-16 21:11   ` [KJ] Re: [PATCH 4/13] ftape: remove cli()/sti() in Alan Cox
2005-01-16 21:11     ` [PATCH 4/13] ftape: remove cli()/sti() in drivers/char/ftape/lowlevel/ftape-io.c Alan Cox
2005-01-16 13:52 ` [PATCH 5/13] generic_serial: remove cli()/sti() in drivers/char/generic_serial.c James Nelson
2005-01-16 13:53 ` [PATCH 6/13] ip2: remove cli()/sti() in drivers/char/ip2main.c James Nelson
2005-01-16 13:53 ` [PATCH 7/13] istallion: remove cli()/sti() in drivers/char/istallion.c James Nelson
2005-01-16 13:53 ` [PATCH 8/13] ite_gpio: remove cli()/sti() in drivers/char/ite_gpio.c James Nelson
2005-01-16 13:53 ` [PATCH 9/13] moxa: remove cli()/sti() in drivers/char/moxa.c James Nelson
2005-01-16 13:53 ` [PATCH 10/13] pcxx: remove cli()/sti() in drivers/char/pcxx.c James Nelson
2005-01-16 13:53 ` [PATCH 11/13] riscom8: remove cli()/sti() in drivers/char/riscom8.c James Nelson
2005-01-16 13:53 ` [PATCH 12/13] serial_tx3912: remove cli()/sti() in drivers/char/serial_tx3912.c James Nelson
2005-01-16 13:53 ` [PATCH 13/13] stallion: remove cli()/sti() in drivers/char/stallion.c James Nelson
2005-01-16 19:25 ` [KJ] Re: [PATCH 0/13] remove cli()/sti() in drivers/char/* Randy.Dunlap
2005-01-16 19:25   ` Randy.Dunlap
2005-01-16 20:13   ` Jim Nelson [this message]
2005-01-16 20:13     ` Jim Nelson
2005-01-16 21:04 ` [KJ] " Andrew Morton
2005-01-16 21:04   ` Andrew Morton
2005-01-16 21:10   ` [KJ] " Alan Cox
2005-01-16 21:10     ` Alan Cox
2005-01-16 22:33     ` [KJ] " Jim Nelson
2005-01-16 22:33       ` Jim Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41EACAE9.9090505@cwazy.co.uk \
    --to=james4765@cwazy.co.uk \
    --cc=akpm@osdl.org \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rddunlap@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.