From: Steve Longerbeam <stevel@mvista.com>
To: Andi Kleen <ak@suse.de>
Cc: Hugh Dickins <hugh@veritas.com>, linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: BUG in shared_policy_replace() ?
Date: Wed, 19 Jan 2005 11:25:52 -0800 [thread overview]
Message-ID: <41EEB440.8010108@mvista.com> (raw)
In-Reply-To: <20050119190927.GM7445@wotan.suse.de>
Andi Kleen wrote:
>On Wed, Jan 19, 2005 at 10:59:16AM -0800, Steve Longerbeam wrote:
>
>
>>Andi Kleen wrote:
>>
>>
>>
>>>>yeah, 2.6.10 makes sense to me too. But I'm working in -mm2, and
>>>>the new2 = NULL line is missing, hence my initial confusion. Trivial
>>>>patch to -mm2 attached. Just want to make sure it has been, or will be,
>>>>put back in.
>>>>
>>>>
>>>>
>>>>
>>>That sounds weird. Can you figure out which patch in mm removes it?
>>>
>>>
>>>
>>>
>>found it:
>>
>>http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.10/2.6.10-mm1/broken-out/mempolicy-optimization.patch
>>
>>
>
>Are you sure? I don't see it touching the new2 free at the end of the function.
>
>
it's not touching the new2 free, it's removing the new2 = NULL which is
the problem.
- new2 = NULL;
WARNING: multiple messages have this Message-ID (diff)
From: Steve Longerbeam <stevel@mvista.com>
To: Andi Kleen <ak@suse.de>
Cc: Hugh Dickins <hugh@veritas.com>, linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: BUG in shared_policy_replace() ?
Date: Wed, 19 Jan 2005 11:25:52 -0800 [thread overview]
Message-ID: <41EEB440.8010108@mvista.com> (raw)
In-Reply-To: <20050119190927.GM7445@wotan.suse.de>
Andi Kleen wrote:
>On Wed, Jan 19, 2005 at 10:59:16AM -0800, Steve Longerbeam wrote:
>
>
>>Andi Kleen wrote:
>>
>>
>>
>>>>yeah, 2.6.10 makes sense to me too. But I'm working in -mm2, and
>>>>the new2 = NULL line is missing, hence my initial confusion. Trivial
>>>>patch to -mm2 attached. Just want to make sure it has been, or will be,
>>>>put back in.
>>>>
>>>>
>>>>
>>>>
>>>That sounds weird. Can you figure out which patch in mm removes it?
>>>
>>>
>>>
>>>
>>found it:
>>
>>http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.10/2.6.10-mm1/broken-out/mempolicy-optimization.patch
>>
>>
>
>Are you sure? I don't see it touching the new2 free at the end of the function.
>
>
it's not touching the new2 free, it's removing the new2 = NULL which is
the problem.
- new2 = NULL;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2005-01-19 19:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-19 0:31 BUG in shared_policy_replace() ? Steve Longerbeam
2005-01-19 12:37 ` Hugh Dickins
2005-01-19 12:37 ` Hugh Dickins
2005-01-19 17:32 ` Steve Longerbeam
2005-01-19 17:32 ` Steve Longerbeam
2005-01-19 17:45 ` Andi Kleen
2005-01-19 17:45 ` Andi Kleen
2005-01-19 18:22 ` Steve Longerbeam
2005-01-19 18:34 ` Andi Kleen
2005-01-19 18:34 ` Andi Kleen
2005-01-19 18:59 ` Steve Longerbeam
2005-01-19 18:59 ` Steve Longerbeam
2005-01-19 19:09 ` Andi Kleen
2005-01-19 19:09 ` Andi Kleen
2005-01-19 19:25 ` Steve Longerbeam [this message]
2005-01-19 19:25 ` Steve Longerbeam
2005-01-19 19:29 ` Andi Kleen
2005-01-19 19:29 ` Andi Kleen
2005-01-19 21:39 ` Andrew Morton
2005-01-19 21:39 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41EEB440.8010108@mvista.com \
--to=stevel@mvista.com \
--cc=ak@suse.de \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.